Re: [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization"

Eric W. Biederman
2007-05-04T14:14:16Z

Rusty Russell <rusty@rustcorp.com.au> writes:

> On Fri, 2007-05-04 at 05:56 -0600, Eric W. Biederman wrote:
>> This reverts commit c9ccf30d77f04064fe5436027ab9d2230c7cdd94.
>>
>> Entering the kernel at startup_32 without passing our real mode data
>> in %esi, and without guaranteeing that physical and virtual addresses
>> are identity mapped makes head.S impossible to maintain.
>
> Your assertion that these #ifdef-contained lines of code are "impossible
> to maintain" is theatrical. I'd prefer to wait until we actually have a
> replacement before we go ripping out working code.

It's not theatrical. It makes this code path extremely brittle and
very hard to change, which over the long term means that it is
impossible to maintain. Quickly resulting in a state where any little
change will break something. See Jeremy's impossible attempt to
detect if we start with physical addresses identity mapped or physical
address mapped at PAGE_OFFSET, just so he can clear the bss before we
test to see if we are running in para-virtualized environment.

The first step in making things better is removing this code (even in
your patches) so this patch doesn't get in the way.

We don't have any working code, there are no in tree users.

Therefore the code should go.

Eric