Re: [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization"

Rusty Russell
2007-05-04T12:13:11Z

On Fri, 2007-05-04 at 05:56 -0600, Eric W. Biederman wrote:
> This reverts commit c9ccf30d77f04064fe5436027ab9d2230c7cdd94.
>
> Entering the kernel at startup_32 without passing our real mode data
> in %esi, and without guaranteeing that physical and virtual addresses
> are identity mapped makes head.S impossible to maintain.

Your assertion that these #ifdef-contained lines of code are "impossible
to maintain" is theatrical. I'd prefer to wait until we actually have a
replacement before we go ripping out working code.

Fortunately, I'm working on such code right now. But as lguest
currently boots with V = P + PAGE_OFFSET, it's not entirely a trivial
matter to change.

Thanks,
Rusty.