From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753376AbXEGBll (ORCPT ); Sun, 6 May 2007 21:41:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753329AbXEGBll (ORCPT ); Sun, 6 May 2007 21:41:41 -0400 Received: from mx1.redhat.com ([66.187.233.31]:37044 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753289AbXEGBlk (ORCPT ); Sun, 6 May 2007 21:41:40 -0400 Subject: Re: RFC airo : wpa support From: Dan Williams To: matthieu castet Cc: Linux Kernel list , netdev@vger.kernel.org In-Reply-To: <463BB946.3000807@free.fr> References: <463BB946.3000807@free.fr> Content-Type: text/plain Date: Sun, 06 May 2007 21:45:36 -0400 Message-Id: <1178502336.25436.3.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2007-05-05 at 00:52 +0200, matthieu castet wrote: > Hi, > > I attach a diff against 2.6.21 for adding wpa support for airo driver. > In then end of 2005 I manage to make work wpa but the code was really > ugly. I manage to find some time to clean it. > > > To support wpa, a new interface of the firmware should be used. This > interface is incompatible with the old interface and using both > interface at the same time make the firmware hang. > > Porting OPEN and WEP mode to new interface need some driver rewrite, and > the old interface should be keep for the older cards (or the cards that > doesn't have newer firmware). > That's why I didn't do it, and I added a module parameter for choosing > between the old driver behavior (with no wpa support) or the driver with > wpa only support. Nice, thanks for cleaning it up. However, having a module option for WPA vs. no WPA gets a big, big NAK from me. We need to be able to have it all co-exist. I'll see if I can clean it up and make the modes able to function in parallel. > The wireless extension handlers are a bit ugly, I will be very happy, if > somebody could help me to clean them. I can take a shot at it. Dan > Any comments are appreciated. > > > Matthieu > > > PS : the lastest version of the driver can be found in > http://svn.gna.org/viewcvs/airo-wpa/branches/kernel/ > > PS2 : There is some remaining trace in the driver for debug purpose, > that will be removed in the final version