[PATCH 2.6.21-mm1] remove unionfs reference to SLAB_CTOR_VERIFY

[PATCH 2.6.21-mm1] remove unionfs reference to SLAB_CTOR_VERIFY

[Lee Schermerhorn]

With unionfs included as a module, 2.6.21-mm1 build broke with:

fs/unionfs/super.c: In function ‘init_once’:
fs/unionfs/super.c:822: error: ‘SLAB_CTOR_VERIFY’ undeclared (first use in this function)
fs/unionfs/super.c:822: error: (Each undeclared identifier is reported only oncefs/unionfs/super.c:822: error: for each function it appears in.)

Looks like it missed the removal of SLAB_CTOR_VERIFY.  

This patch matches how the situation was addressed elsewhere
throughout the kernel.  Fixes the problem for me...

Signed-off-by:  Lee Schermerhorn <lee.schermerhorn@hp.com>

 fs/unionfs/super.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: Linux/fs/unionfs/super.c
===================================================================
--- Linux.orig/fs/unionfs/super.c	2007-05-07 10:00:21.000000000 -0400
+++ Linux/fs/unionfs/super.c	2007-05-07 10:40:51.000000000 -0400
@@ -819,8 +819,7 @@ static void init_once(void *v, struct km
 {
 	struct unionfs_inode_info *i = v;
 
-	if ((flags & (SLAB_CTOR_VERIFY | SLAB_CTOR_CONSTRUCTOR)) ==
-	    SLAB_CTOR_CONSTRUCTOR)
+	if (flags & SLAB_CTOR_CONSTRUCTOR)
 		inode_init_once(&i->vfs_inode);
 }
 

Re: [PATCH 2.6.21-mm1] remove unionfs reference to SLAB_CTOR_VERIFY

[Josef Sipek]

On Mon, May 07, 2007 at 11:22:32AM -0400, Lee Schermerhorn wrote:
> With unionfs included as a module, 2.6.21-mm1 build broke with:
> 
> fs/unionfs/super.c: In function ‘init_once’:
> fs/unionfs/super.c:822: error: ‘SLAB_CTOR_VERIFY’ undeclared (first use in this function)
> fs/unionfs/super.c:822: error: (Each undeclared identifier is reported only oncefs/unionfs/super.c:822: error: for each function it appears in.)
> 
> Looks like it missed the removal of SLAB_CTOR_VERIFY.  
 
This fix (by Adrian Bunk) is already in the unionfs git tree.

Thanks anyway.

Josef "Jeff" Sipek.

-- 
Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are, by
definition, not smart enough to debug it.
		- Brian W. Kernighan 

Re: [PATCH 2.6.21-mm1] remove unionfs reference to SLAB_CTOR_VERIFY

[Lee Schermerhorn]

On Mon, 2007-05-07 at 13:16 -0400, Josef Sipek wrote:
> On Mon, May 07, 2007 at 11:22:32AM -0400, Lee Schermerhorn wrote:
> > With unionfs included as a module, 2.6.21-mm1 build broke with:
> > 
> > fs/unionfs/super.c: In function ‘init_once’:
> > fs/unionfs/super.c:822: error: ‘SLAB_CTOR_VERIFY’ undeclared (first use in this function)
> > fs/unionfs/super.c:822: error: (Each undeclared identifier is reported only oncefs/unionfs/super.c:822: error: for each function it appears in.)
> > 
> > Looks like it missed the removal of SLAB_CTOR_VERIFY.  
>  
> This fix (by Adrian Bunk) is already in the unionfs git tree.
> 
> Thanks anyway.

OK.  I just ran into the issue this am with 21-mm1.  I didn't see the
fix in the MARC archives, but they haven't been updated since ~3may.
Sorry for the noise...

Lee