From: Milian Wolff <milian.wolff@kdab.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dmitri Prokhorov <Dmitry.Prohorov@intel.com>
Subject: Re: [RFC PATCH] perf/core: exposing type of context-switch-out event
Date: Thu, 01 Mar 2018 20:19:47 +0100 [thread overview]
Message-ID: <11785831.IWU0hVXpm2@agathebauer> (raw)
In-Reply-To: <20180301180805.GI21543@tassilo.jf.intel.com>
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
On Donnerstag, 1. März 2018 19:08:05 CET Andi Kleen wrote:
> On Thu, Mar 01, 2018 at 06:40:04PM +0300, Alexey Budankov wrote:
> > Hi,
> >
> > This patch prototypes exposing the type of context-switch-out event using
> > PERF_RECORD_MISC_EXT_RESERVED bit for PERF_RECORD_SWITCH[_CPU_WIDE]
> > records.
> It would be better to define an actually named bit in perf_event.h.
> It can be the same value.
>
> Also we would need a patch for perf script / perf report -D to print this
> information.
>
> The rest looks good to me.
Please also add documentation Documentation/perf.data-file-format.txt, but I
just noticed that not even PERF_RECORD_SWITCH is documented there...
Otherwise I also think that this would be a very nice feature addition!
--
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt, C++ and OpenGL Experts
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3826 bytes --]
next prev parent reply other threads:[~2018-03-01 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 15:40 [RFC PATCH] perf/core: exposing type of context-switch-out event Alexey Budankov
2018-03-01 18:08 ` Andi Kleen
2018-03-01 19:19 ` Milian Wolff [this message]
2018-03-01 19:36 ` Andi Kleen
2018-03-01 20:57 ` Milian Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11785831.IWU0hVXpm2@agathebauer \
--to=milian.wolff@kdab.com \
--cc=Dmitry.Prohorov@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox