From: Bryan WU <bryan.wu@analog.com>
To: David Brownell <david-b@pacbell.net>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
spi-devel-general@lists.sourceforge.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [spi-devel-general] adding bits_per_word to struct spi_board_info to mirror struct spi_device
Date: Tue, 08 May 2007 15:31:35 +0800 [thread overview]
Message-ID: <1178609496.5222.24.camel@roc-desktop> (raw)
In-Reply-To: <200705072200.26888.david-b@pacbell.net>
On Mon, 2007-05-07 at 22:00 -0700, David Brownell wrote:
> On Monday 07 May 2007, Bryan WU wrote:
>
> > currently, there are some duplicated data members in spi_device struct
> > spi_board_info struct. This two structs are confused driver writers and
> > boards driver users.
>
> How would that confusion arise? Only arch/.../board-xxx.c writers
> normally even see spi_board_info; the exception is that someone who
> writes an add-on board -- maybe a USB-to-SPI adapter -- would call the
> rarely used spi_new_device() routine.
>
> Developers writing a SPI drivers -- controller drivers touching some
> SOC's serial controller hardware, or "struct spi_driver" protocol code
> talking to a chip through such a controller -- never see board info.
> They only see "struct spi_device". So I don't see why they would have
> a reason to be confused.
>
> - Dave
Yes, I agree with you.
spi_board_info ---> board writers.
spi_device ---> spi device driver writers.
It is very clear for me, a spi_master driver developer.
But how does a board writer know the capabilities which the target
spi_device driver supports? For example, a board writer use 16
bits_per_word in a spi_board_info, while the spi_device does not support
this. And maybe other special function spi_device driver can provide but
board writer doesn't know or doesn't know how to use this in
spi_board_info.
So can we just use one struct for both board writers and spi device
driver developers?
Thanks
-Bryan Wu
next prev parent reply other threads:[~2007-05-08 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 10:05 adding bits_per_word to struct spi_board_info to mirror struct spi_device Mike Frysinger
2007-04-25 15:13 ` [spi-devel-general] " David Brownell
2007-05-07 23:47 ` Mike Frysinger
2007-05-08 3:48 ` Bryan WU
2007-05-08 5:00 ` David Brownell
2007-05-08 7:31 ` Bryan WU [this message]
2007-05-08 4:53 ` David Brownell
2007-05-08 5:24 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178609496.5222.24.camel@roc-desktop \
--to=bryan.wu@analog.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox