From: Paul Fulghum <paulkf@microgate.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux console project <linuxconsole-dev@lists.sourceforge.net>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Use tty_schedule in VT code.
Date: Tue, 08 May 2007 15:32:41 -0500 [thread overview]
Message-ID: <1178656361.14867.7.camel@x2.microgate.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705082107460.3459@pentafluge.infradead.org>
On Tue, 2007-05-08 at 21:10 +0100, James Simmons wrote:
>
> This patch has the VT subsystem use tty_schedule_flip instead of
> con_schedule_flip. There are two ways we can approach this. We can
> do the below path or extend tty_schedule_flip to accept a time field.
> Comments welcomed.
This looks reasonable.
I don't think a time field is necessary. In fact, I think the
scheduled_delayed_work() in tty_schedule_flip() should use a
time of 0 just like con_schedule_flip().
As the tty flip buffer code has evolved, that delay value of 1
was carried along. It may have had some historical purpose, but
I can't figure it out and it appears to have no use currently.
It would be better for performance to process the receive data
as soon as possible (delay value of 0).
--
Paul Fulghum
Microgate Systems, Ltd
next prev parent reply other threads:[~2007-05-08 20:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 20:10 [PATCH] Use tty_schedule in VT code James Simmons
2007-05-08 20:32 ` Paul Fulghum [this message]
2007-05-09 20:58 ` Paul Fulghum
2007-05-09 20:56 ` James Simmons
2007-05-09 23:02 ` Paul Fulghum
-- strict thread matches above, loose matches on Subject: below --
2007-07-17 18:37 James Simmons
2007-07-17 18:49 ` Samuel Thibault
2007-07-17 19:17 ` James Simmons
2007-07-17 20:31 ` Paul Fulghum
2007-07-17 19:24 ` Linus Torvalds
2007-07-17 20:35 ` Paul Fulghum
2007-07-17 19:44 ` Linus Torvalds
2007-07-17 19:52 ` James Simmons
2007-07-17 20:42 ` Linus Torvalds
2007-07-17 23:35 ` Alan Cox
2007-07-18 18:17 ` James Simmons
2007-07-18 18:27 ` Paul Fulghum
2007-07-18 19:57 ` James Simmons
2007-07-18 21:12 ` Paul Fulghum
2007-07-18 20:08 ` Linus Torvalds
2007-07-18 21:36 ` Alan Cox
2007-07-17 21:06 ` Paul Fulghum
2007-07-17 20:15 ` James Simmons
2007-07-17 21:33 ` Paul Fulghum
2007-07-18 17:19 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178656361.14867.7.camel@x2.microgate.com \
--to=paulkf@microgate.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxconsole-dev@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox