From: Paul Fulghum <paulkf@microgate.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] synclink_gt add compat_ioctl
Date: Tue, 08 May 2007 16:14:03 -0500 [thread overview]
Message-ID: <1178658843.4152.12.camel@x2.microgate.com> (raw)
In-Reply-To: <200705060227.29450.arnd@arndb.de>
On Sun, 2007-05-06 at 02:27 +0200, Arnd Bergmann wrote:
> Now that you mention the duplication, this sounds wrong as well. The easiest
> solution is probably to just put the definition of your data structure
> inside of #ifdef CONFIG_COMPAT in the header file.
The structure definition was already inside of #ifdef CONFIG_COMPAT
The problem is including linux/compat.h inside of synclink.h
causes an error on i386. The headerscheck facility is spitting
out an error even if the #include <linux/compat.h> is inside of
#ifdef CONFIG_COMPAT
make[3]: *** No rule to make target
`/usr/src/devel/usr/include/linux/.check.synclink.h', needed by
`__headerscheck'. Stop.
linux/kexec.h includes linux/compat.h without a similar error,
though that is inside of a #ifdef CONFIG_KEXEC
Moving linux/compat.h from synclink.h to synclink_gt.c
removes the error.
This is the last error standing in my way and I'm trying
to figure out the rules for when and where you are allowed
to use compat.h, I'm not familiar with the headerscheck
facility so I'm not sure what it is looking for and the
error is not very helpful. There is nothing in Documentation
covering it.
--
Paul Fulghum
Microgate Systems, Ltd
next prev parent reply other threads:[~2007-05-08 21:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 18:01 [PATCH] synclink_gt add compat_ioctl Paul Fulghum
2007-05-04 0:53 ` Andrew Morton
2007-05-04 21:08 ` Paul Fulghum
2007-05-05 10:58 ` Arnd Bergmann
2007-05-05 13:57 ` Paul Fulghum
2007-05-06 0:27 ` Arnd Bergmann
2007-05-08 21:14 ` Paul Fulghum [this message]
2007-05-08 22:07 ` Arnd Bergmann
2007-05-08 23:19 ` Paul Fulghum
2007-05-05 0:48 ` Andrew Morton
2007-05-04 19:08 ` Paul Fulghum
-- strict thread matches above, loose matches on Subject: below --
2007-05-09 16:19 Paul Fulghum
2007-05-02 20:21 Paul Fulghum
2007-05-02 22:09 ` Arnd Bergmann
2007-05-02 23:39 ` Paul Fulghum
2007-05-02 22:47 ` Arnd Bergmann
2007-05-03 0:05 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178658843.4152.12.camel@x2.microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).