public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] V4L: videodev, allow VIDIOCGMBUF
Date: Tue, 08 May 2007 18:15:38 -0300	[thread overview]
Message-ID: <1178658938.18383.375.camel@localhost> (raw)
In-Reply-To: <32177258712660011096@wsc.cz>

Hi Jiri,

>	if (_IOC_TYPE(cmd)=='v')
> -		return v4l_compat_translate_ioctl(inode,file,cmd,arg,
> +#ifdef CONFIG_VIDEO_V4L1_COMPAT
> +		if (cmd != VIDIOCGMBUF) /* <-- handled below vvv */
> +#endif
> +			return v4l_compat_translate_ioctl(inode,file,cmd,arg,
>  						__video_do_ioctl);
> 
I've committed two patches on my -git tree that will fix the issue
you're pointing. 

In fact, all the above code should be handled only if V4L1_COMPAT is
enabled. The fixes are at the following patches:

http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=11fe647ca79d1e6381f954a7fe790a1157c803dc

http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=853fa89dd933b90f820d4bd46a71542bfb3d5967

Cheers,
Mauro


      parent reply	other threads:[~2007-05-08 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-08 18:24 [PATCH 1/2] V4L: videodev, allow VIDIOCGMBUF Jiri Slaby
2007-05-08 18:25 ` [PATCH 2/2] V4L: v4l1-compat, fix VIDIOCSPICT for non-OVERLAY Jiri Slaby
2007-05-08 21:20   ` Mauro Carvalho Chehab
2007-05-08 21:15 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178658938.18383.375.camel@localhost \
    --to=mchehab@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox