From: Rusty Russell <rusty@rustcorp.com.au>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Chris Wright <chrisw@sous-sol.org>,
David Howells <dhowells@redhat.com>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>
Subject: Re: [patch 3/4] split usermodehelper setup from execution
Date: Wed, 09 May 2007 09:49:31 +1000 [thread overview]
Message-ID: <1178668171.7286.55.camel@localhost.localdomain> (raw)
In-Reply-To: <20070508205517.256147592@goop.org>
On Tue, 2007-05-08 at 13:51 -0700, Jeremy Fitzhardinge wrote:
> plain text document attachment (usermodehelper-split-init.patch)
> Rather than having hundreds of variations of call_usermodehelper for
> various pieces of usermode state which could be set up, split the
> info allocation and initialization from the actual process execution.
Erk, I hadn't realized how extended call_usermodehelper had become.
call_usermodehelper_pipe()? Erk. Grepping... for core dumping via a
process? Without modifying the ELF core dumper (at least) to handle
short writes? Why not dump it in an agreed location and exec the
process with that as an arg?
When did this go in? 2.6.19... hmm, too late to rip it out I guess 8(
Anyway, I'm not sure exposing an open-ended interface wins: refactoring
internally definitely makes sense though.
Rusty.
next prev parent reply other threads:[~2007-05-08 23:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 20:51 [patch 0/4] A series of cleanup patches Jeremy Fitzhardinge
2007-05-08 20:51 ` [patch 1/4] add kstrndup Jeremy Fitzhardinge
2007-05-08 21:56 ` Randy Dunlap
2007-05-08 20:51 ` [patch 2/4] add argv_split() Jeremy Fitzhardinge
2007-05-08 21:59 ` Randy Dunlap
2007-05-08 22:31 ` Jan Engelhardt
2007-05-08 22:36 ` Jeremy Fitzhardinge
2007-05-08 20:51 ` [patch 3/4] split usermodehelper setup from execution Jeremy Fitzhardinge
2007-05-08 22:01 ` Randy Dunlap
2007-05-08 22:00 ` Jeremy Fitzhardinge
2007-05-08 22:10 ` Randy Dunlap
2007-05-08 23:49 ` Rusty Russell [this message]
2007-05-09 0:00 ` Jeremy Fitzhardinge
2007-05-08 20:51 ` [patch 4/4] Add common orderly_poweroff() Jeremy Fitzhardinge
2007-05-08 21:45 ` Len Brown
2007-05-08 22:06 ` Randy Dunlap
2007-05-09 12:52 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178668171.7286.55.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=B.Steinbrink@gmx.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=dhowells@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox