Re: [patch 3/3] clockevents: Fix resume logic - updated version

Thomas Gleixner
2007-05-09T13:16:52Z

On Wed, 2007-05-09 at 15:12 +0200, Rafael J. Wysocki wrote:
> On Wednesday, 9 May 2007 14:24, Thomas Gleixner wrote:
> > On Wed, 2007-05-09 at 13:45 +0200, Rafael J. Wysocki wrote:
> > > On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote:
> > > > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote:
> > > > > > I suspect I just tested the wrong thing yesterday. Let me recheck just
> > > > > > these patches against 2.6.21.
> > > > >
> > > > > yup, same hang with just these three:
> > > > >
> > > > > origin
> > > > > clocksource-fix-resume-logic
> > > > > clockevents-fix-resume-logic-updated-version
> > > >
> > > > I have no idea, how this affects acpi_evaluate_object()
> > >
> > > I think the problem is that the ACPI code ordering here is broken in a
> > > difficult to fix way.
> >
> > Any explanation aside of witchcraft why this is affected by the clock
> > event resume changes ?
>
> Well, where is unregister_time_interpolator() called from?

# grep -rn unregister_time_interpolator .
./kernel/timer.c:1893:unregister_time_interpolator(struct time_interpolator *ti)
./include/linux/timex.h:270:extern void unregister_time_interpolator(struct time_interpolator *);

I don't see a caller. i386 does not use time interpolator anyway.

# find -iname Kconfig | xargs grep TIME_INTERPOLATION
./arch/sparc64/Kconfig:37:config TIME_INTERPOLATION
./arch/ia64/Kconfig:60:config TIME_INTERPOLATION

tglx