Re: [patch 3/3] clockevents: Fix resume logic - updated version

Thomas Gleixner
2007-05-12T16:58:45Z

On Sat, 2007-05-12 at 09:51 -0700, Andrew Morton wrote:
> The locking in clocksource_resume_watchdog looks pretty pointless anyway.
> Can't we just delete it?
>
> The only thing it can race against is, conceivably,
>
> resumed = watchdog_resumed;
> if (unlikely(resumed))
> watchdog_resumed = 0;
>
> which could be solved by using test_and_clear_bit().

True. I'll redo it.

> Does anyone have any theories about my lockdep warning?

Can you upload a snapshot of your current queue ?

tglx