Re: [patch 3/3] clockevents: Fix resume logic - updated version

Andrew Morton
2007-05-13T22:36:38Z

On Sun, 13 May 2007 22:07:39 +0200 Ingo Molnar <mingo@elte.hu> wrote:

>
> * Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > Yeah, I expect quite a few people will start seeing that. iirc it was
> > triggered by a couple of changes: a local_irq_save/local_irq_restore
> > in sched_clock() and a change Jeremy made to the softlockup detector.
>
> hm, i specifically asked to not do local_irq_save/restore in
> sched_clock(). It's the _scheduler_ clock and it very absolutely
> positively needs no flags save/restore.
>

It got taken out again.

It doesn't matter though: a local_irq_save/restore in some callee shouldn't
cause the locking API tests to break. And they're apparently now breaking
without that local_irq_save/restore in there anyway.