public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH] timekeeping fix mismerge
Date: Mon, 14 May 2007 21:17:23 +0200	[thread overview]
Message-ID: <1179170243.7074.13.camel@chaos> (raw)
In-Reply-To: <20070514115835.19be36d0.akpm@linux-foundation.org>

On Mon, 2007-05-14 at 11:58 -0700, Andrew Morton wrote:
> Urgh, that was probably me trying to manage the maelstrom from a million
> monkeys mucking in the same code for multiple months, sigh.
> 
> So what do "broke" and "fix" mean in this context?  What are the
> consequences of this bug, and of its fix?  Is the above appropriate for
> 2.6.21.x and if so why?

clocksource_resume() is not called except from
unregister_time_interpolator(), which is definitely the wrong place.

No 2.6.21.x material, as the move of the timekeeping code happened after
2.6.21.

	tglx



  reply	other threads:[~2007-05-14 19:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-14  9:10 [PATCH] timekeeping fix mismerge Thomas Gleixner
2007-05-14 18:58 ` Andrew Morton
2007-05-14 19:17   ` Thomas Gleixner [this message]
2007-05-14 19:25 ` Linus Torvalds
2007-05-14 20:33   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179170243.7074.13.camel@chaos \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox