From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>, hch <hch@infradead.org>
Subject: Re: [PATCH 1/6] lguest: host code tidyups
Date: Wed, 16 May 2007 09:32:16 +1000 [thread overview]
Message-ID: <1179271936.23574.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20070515214756.b8020d4e.sfr@canb.auug.org.au>
On Tue, 2007-05-15 at 21:47 +1000, Stephen Rothwell wrote:
> On Tue, 15 May 2007 21:42:35 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell <rusty@rustcorp.com.au> wrote:
> > > - on_each_cpu(adjust_pge, 0, 0, 1);
> > > + on_each_cpu(adjust_pge, (void *)0, 0, 1);
> >
> > Sorry? What ever happened to a simple NULL?
>
> Oh, I guess that is an explicit (numeric) 0 (of some type) caste to
> "void *" because of the prototype - rather than not passing anything?
Indeed. We really want to pass a bool, but on_each_cpu uses a void *.
Hence the clearest solution seemed "(void *)0" and "(void *)1" in the
callers.
Thanks,
Rusty.
next prev parent reply other threads:[~2007-05-15 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 1:17 [PATCH 1/6] lguest: host code tidyups Rusty Russell
2007-05-15 1:18 ` [PATCH 2/6] lguest: kbuild tidyups Rusty Russell
2007-05-15 1:19 ` [PATCH 3/6] lguest: guest tidyups Rusty Russell
2007-05-15 1:20 ` [PATCH 4/6] lguest: netdriver tidyups and a bugfix Rusty Russell
2007-05-15 1:21 ` [PATCH 5/6] lguest: console driver tidyups Rusty Russell
2007-05-15 1:28 ` [PATCH 6/6] lguest: block " Rusty Russell
2007-05-15 11:42 ` [PATCH 1/6] lguest: host code tidyups Stephen Rothwell
2007-05-15 11:47 ` Stephen Rothwell
2007-05-15 23:32 ` Rusty Russell [this message]
2007-05-16 7:00 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179271936.23574.2.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox