From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] i386: fix early usage of atomic_add_return and local_add_return on real i386
Date: Tue, 22 May 2007 12:37:28 +0200 [thread overview]
Message-ID: <1179830248.12708.120.camel@chaos> (raw)
In-Reply-To: <200705221234.28289.ak@suse.de>
On Tue, 2007-05-22 at 12:34 +0200, Andi Kleen wrote:
> On Tuesday 22 May 2007 11:48, Thomas Gleixner wrote:
> > The check (boot_cpu_data.x86 == 3) in atomic_add_return() and
> > local_add_return() fails, when those operations are used before
> > boot_cpu_data is filled in.
> >
> > Change the check to (boot_cpu_data.x86 <= 3) to fix this.
>
> That's a critical boot fix for 386, right?
Yup. Hit me with some debug option enabled, but might happen anywhere
else too.
tglx
prev parent reply other threads:[~2007-05-22 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 9:48 [PATCH] i386: fix early usage of atomic_add_return and local_add_return on real i386 Thomas Gleixner
2007-05-22 10:34 ` Andi Kleen
2007-05-22 10:37 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179830248.12708.120.camel@chaos \
--to=tglx@linutronix.de \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox