From: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
guanjing <guanjing@cmss.chinamobile.com>,
<mcoquelin.stm32@gmail.com>
Cc: <linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall
Date: Tue, 12 Nov 2024 10:40:42 +0100 [thread overview]
Message-ID: <1179b3a6-e430-4d9a-8f86-470e8cbe5738@foss.st.com> (raw)
In-Reply-To: <cfb1caed-9402-4148-831d-57c50bdf6a27@foss.st.com>
On 11/12/24 10:25, Alexandre TORGUE wrote:
> Hi
>
> On 11/9/24 06:50, guanjing wrote:
>> Remove misplaced colon in stm32_firewall_get_firewall()
>> which results in a syntax error when the code is compiled
>> without CONFIG_STM32_FIREWALL.
>>
>> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
>> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
>> ---
>> include/linux/bus/stm32_firewall_device.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/bus/stm32_firewall_device.h
>> b/include/linux/bus/stm32_firewall_device.h
>> index 18e0a2fc3816..5178b72bc920 100644
>> --- a/include/linux/bus/stm32_firewall_device.h
>> +++ b/include/linux/bus/stm32_firewall_device.h
>> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct
>> stm32_firewall *firewall, u32 su
>> #else /* CONFIG_STM32_FIREWALL */
>> int stm32_firewall_get_firewall(struct device_node *np, struct
>> stm32_firewall *firewall,
>> - unsigned int nb_firewall);
>> + unsigned int nb_firewall)
>> {
>> return -ENODEV;
>> }
>
> Acked-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>
> Thanks
> Alex
Hi, please use get_maintainers.pl script next time so that
adequate people are put in To/CC.
Nevertheless, thanks for the patch!
Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
next prev parent reply other threads:[~2024-11-12 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 5:50 [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall guanjing
2024-11-12 9:25 ` Alexandre TORGUE
2024-11-12 9:40 ` Gatien CHEVALLIER [this message]
2024-11-21 9:19 ` [PATCH v2] firewall: remove misplaced semicolon fromstm32_firewall_get_firewall guanjing
2024-11-21 21:16 ` Jeff Johnson
2024-12-12 15:32 ` [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179b3a6-e430-4d9a-8f86-470e8cbe5738@foss.st.com \
--to=gatien.chevallier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=guanjing@cmss.chinamobile.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox