From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: Aubrey Li <aubreylee@gmail.com>,
Christoph Lameter <clameter@sgi.com>,
Bernhard Walle <bwalle@suse.de>,
linux-scsi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: RE: [PATCH] [scsi] Remove __GFP_DMA
Date: Thu, 24 May 2007 09:59:12 -0500 [thread overview]
Message-ID: <1180018752.3692.16.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <AE4F746F2AECFC4DA4AADD66A1DFEF019E1CAA@otce2k301.adaptec.com>
On Thu, 2007-05-24 at 09:24 -0400, Salyzyn, Mark wrote:
> So, is the sequence:
>
> p = kmalloc(upsg->sg[i].count,GFP_KERNEL);
> . . .
> addr = pci_map_single(dev->pdev, p, upsg->sg[i].count,
> data_dir);
>
> Going to ensure that we have a 31 bit (not 32 bit) physical address?
No, unfortunately. Implementing kmalloc_mask() and kmalloc_dev() was
something I said I'd do ... about two years ago.
> If not, then I reject this patch. We can not consider replacement with
> pci_alloc_consistent until it works on AMD respecting the DMA masks.
It should, I believe ... x86_64 has a complex allocation scheme where
for masks < 32 bit it first tries in GFP_DMA32 and sees if it gets lucky
before falling back to GFP_DMA. i386 just goes straight to GFP_DMA.
James
next prev parent reply other threads:[~2007-05-24 14:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 15:15 [PATCH] [scsi] Remove __GFP_DMA Bernhard Walle
2007-05-22 21:44 ` Christoph Lameter
2007-05-23 2:41 ` Aubrey Li
2007-05-23 15:18 ` James Bottomley
2007-05-23 15:55 ` Robert P. J. Day
2007-05-23 16:17 ` James Bottomley
2007-05-23 19:17 ` Salyzyn, Mark
2007-05-23 19:38 ` Alan Cox
2007-05-27 19:46 ` James Bottomley
2007-05-24 13:24 ` Salyzyn, Mark
2007-05-24 14:59 ` James Bottomley [this message]
2007-05-24 17:00 ` Christoph Lameter
2007-05-24 17:15 ` James Bottomley
2007-05-24 17:22 ` Christoph Lameter
2007-05-24 17:26 ` James Bottomley
2007-05-24 16:59 ` Christoph Lameter
[not found] <fa.6bUV4KR+za7HW4tT2WBlccqvoq0@ifi.uio.no>
[not found] ` <fa.NYl60pD1cwd1ESdKNCPaOwSz1WA@ifi.uio.no>
[not found] ` <fa.hW9tQQfgwmXj0gAKQoWXOxVzpvk@ifi.uio.no>
[not found] ` <fa.xLFpJ54sTvGq6YIol2Ew31Rrq2s@ifi.uio.no>
[not found] ` <fa.JZsPKKyEKOAfxp6reMY5ZwSNjQU@ifi.uio.no>
[not found] ` <fa.txrEcCPLxIukzeVBv7UG39WubcI@ifi.uio.no>
2007-05-24 5:28 ` Robert Hancock
2007-05-24 10:08 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180018752.3692.16.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=aubreylee@gmail.com \
--cc=bwalle@suse.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox