From: Richard Purdie <rpurdie@rpsys.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jan Kratochvil <honza@jikos.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Support for controlling leds on xbox 360 pad.
Date: Wed, 30 May 2007 17:32:20 +0100 [thread overview]
Message-ID: <1180542740.5835.135.camel@localhost.localdomain> (raw)
In-Reply-To: <d120d5000705300756t24d4a58ey1f4130bef22f8309@mail.gmail.com>
Hi Dmitry,
On Wed, 2007-05-30 at 10:56 -0400, Dmitry Torokhov wrote:
> Do you think it makes sense to split the driver (and Kconfig options)
> between input and leds directories as Jan had done? I know that I
> prefer to keep anything input related in input directory because it
> makes my life as maintainer easier and I bet you prefer the same but
> it does not always work well for multifunction devices or devices
> using several subsystems...
In ideal world having the code in drivers/leds would be preferred but if
you want to add the LED code directly to the input driver in this case I
have no objection and it probably makes sense. The LED code is already
spread about a bit anyway...
Cheers,
Richard
next prev parent reply other threads:[~2007-05-30 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 21:11 [PATCH] Support for controlling leds on xbox 360 pad Jan Kratochvil
2007-05-29 21:29 ` Jan Kratochvil
2007-05-29 21:41 ` Richard Purdie
2007-05-30 3:17 ` Dmitry Torokhov
2007-05-30 14:56 ` Dmitry Torokhov
2007-05-30 16:32 ` Richard Purdie [this message]
2007-05-30 21:37 ` Jan Kratochvil
2007-06-03 18:02 ` Jan Kratochvil
2007-06-03 18:07 ` Jan Kratochvil
2007-06-15 4:15 ` Dmitry Torokhov
2007-06-15 5:06 ` Dmitry Torokhov
2007-05-31 14:07 ` Pavel Machek
2007-05-31 15:53 ` Jan Kratochvil
2007-05-31 16:09 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180542740.5835.135.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=dmitry.torokhov@gmail.com \
--cc=honza@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox