From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes
Date: Wed, 06 Jun 2007 08:59:28 +1000 [thread overview]
Message-ID: <1181084368.31677.149.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0706051548290.23673@alien.or.mcafeemobile.com>
On Tue, 2007-06-05 at 15:50 -0700, Davide Libenzi wrote:
> > What about the code in __dequeue_signal though ? That notifier thing
> is
> > used by the DRI though I'm not sure what would happen if it acts on
> the
> > wrong task.
>
> Hmm, looking at the comments in block_all_signals(), it seems that
> they're
> interested in the fact that a specific task dequeue the signal. So,
> at
> a first sight, it seems that such code should not not be executed if
> another task dequeue the message. What do you think?
Yes, I think the idea is that the DRM uses that to prevent signals to be
delivered to the task that is blocking them with the notifier (I have no
idea why they can't use the normal block mecanism for that... looks like
a hack to me).
So I suppose it's fine, as long as you add a test of tsk == current to
avoid calling it.
Ben.
next prev parent reply other threads:[~2007-06-05 23:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 1:25 [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes Benjamin Herrenschmidt
2007-06-05 1:44 ` Linus Torvalds
2007-06-05 2:10 ` Benjamin Herrenschmidt
2007-06-05 2:38 ` Davide Libenzi
2007-06-05 3:22 ` Benjamin Herrenschmidt
2007-06-05 6:09 ` Nicholas Miell
2007-06-05 7:27 ` Benjamin Herrenschmidt
2007-06-05 23:51 ` Nicholas Miell
2007-06-06 0:03 ` Benjamin Herrenschmidt
2007-06-06 0:11 ` Davide Libenzi
2007-06-06 0:15 ` Nicholas Miell
2007-06-06 0:37 ` Davide Libenzi
2007-06-06 0:58 ` signalfd API issues (was Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes) Nicholas Miell
2007-06-06 2:50 ` Benjamin Herrenschmidt
2007-06-06 3:29 ` Davide Libenzi
2007-06-06 3:37 ` Linus Torvalds
2007-06-06 4:08 ` Nicholas Miell
2007-06-06 4:18 ` Benjamin Herrenschmidt
2007-06-06 4:35 ` Davide Libenzi
2007-06-06 6:47 ` Benjamin Herrenschmidt
2007-06-06 22:36 ` Davide Libenzi
2007-06-06 3:52 ` Benjamin Herrenschmidt
2007-06-06 12:52 ` Jeff Dike
2007-06-06 22:43 ` Paul Mackerras
2007-06-07 2:20 ` Jeff Dike
2007-06-07 3:29 ` Benjamin Herrenschmidt
2007-06-07 13:59 ` Jeff Dike
2007-06-07 3:21 ` Benjamin Herrenschmidt
2007-06-05 15:52 ` [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes Davide Libenzi
2007-06-05 22:15 ` Benjamin Herrenschmidt
2007-06-05 22:50 ` Davide Libenzi
2007-06-05 22:59 ` Benjamin Herrenschmidt [this message]
2007-06-06 0:11 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181084368.31677.149.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox