Re: [PATCH 3/6] lguest suppress IDE probing

Matt Mackall
2007-06-05T15:32:46Z

On Wed, Jun 06, 2007 at 12:58:03AM +1000, Rusty Russell wrote:
> The IDE probe is the slowest part of boot: by suppressing it we cut
> boot from from 3 seconds to half a second.
>
> AFAICT, the commandline is the easiest way to suppress the probing.

Switching to libata accomplishes the same and isn't quite as ugly. I'd
just drop this patch and put a note about it in lguest.txt, as libata
seems to be the fashionable thing to do these days.

> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> drivers/lguest/lguest.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> ===================================================================
> --- a/drivers/lguest/lguest.c
> +++ b/drivers/lguest/lguest.c
> @@ -605,6 +605,12 @@ __init void lguest_init(void *boot)
> acpi_disabled = 1;
> acpi_ht = 0;
> #endif
> +#ifdef CONFIG_BLK_DEV_IDE
> + /* Saves three seconds off boot time. */
> + strcat(boot_command_line,
> + " ide0=noprobe ide1=noprobe ide2=noprobe"
> + " ide3=noprobe ide4=noprobe ide5=noprobe");
> +#endif
>
> add_preferred_console("hvc", 0, NULL);
>
>

--
Mathematics is the supreme nostalgia of our time.