Re: [PATCH 4/6] lguest don't signal like crazy, use LHREQ_BREAK command

Matt Mackall
2007-06-06T01:00:43Z

On Wed, Jun 06, 2007 at 10:07:46AM +1000, Rusty Russell wrote:
> On Tue, 2007-06-05 at 10:34 -0500, Matt Mackall wrote:
> > On Wed, Jun 06, 2007 at 01:00:06AM +1000, Rusty Russell wrote:
> > > We currently use a "waker" process: a child of the launcher which
> > > selects() on the incoming file descriptors. It sends a SIGUSR1 to the
> > > launcher whenever select() returns to kick the launcher out of the
> > > kernel.
> >
> > If I break out of lguest with three ctrl-Cs, this leaves one of the
> > lguest processes running with /dev/lguest held open.
>
> This patch, or the previous version I sent? The previous one had this
> issue, so this one takes some care to kill the waker and I haven't seen
> it since:
>
> /* Make sure waker is not blocked in BREAK */
> u32 args[] = { LHREQ_BREAK, 0 };
> close(waker_fd);
> write(fd, args, sizeof(args));
> exit(2);

Probably the one you sent earlier.

--
Mathematics is the supreme nostalgia of our time.