From: john stultz <johnstul@us.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -rt] Fix TASKLET_STATE_SCHED WARN_ON()
Date: Wed, 06 Jun 2007 10:39:55 -0700 [thread overview]
Message-ID: <1181151595.6275.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20070606094548.GA9511@elte.hu>
On Wed, 2007-06-06 at 11:45 +0200, Ingo Molnar wrote:
> * john stultz <johnstul@us.ibm.com> wrote:
>
> > This fix avoids this race by making sure *after* we've locked the
> > tasklet that the STATE_SCHED bit is set before adding it to the list.
> >
> > Does it look ok to you?
>
> ah - nice!! What would be the worst-case effect of this bug? (besides
> the WARN_ON()?) In any case, this fix will be in -rt10. Great work!
The only side effect I can come up w/ is you might run a tasklet 3 times
if it was only scheduled twice.
thanks
-john
next prev parent reply other threads:[~2007-06-06 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 2:17 [PATCH -rt] Fix TASKLET_STATE_SCHED WARN_ON() john stultz
2007-06-06 9:45 ` Ingo Molnar
2007-06-06 17:39 ` john stultz [this message]
2007-06-06 10:31 ` Jesper Juhl
2007-06-14 21:20 ` john stultz
-- strict thread matches above, loose matches on Subject: below --
2007-06-15 15:52 Oleg Nesterov
2007-06-15 21:51 ` john stultz
2007-06-15 23:59 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181151595.6275.1.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox