public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: v4l-dvb-maintainer@linuxtv.org, linux-dvb@linuxtv.org,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: drivers/media/dvb/b2c2/flexcop-dma.c uses PCI DMA API
Date: Thu, 07 Jun 2007 09:50:56 -0300	[thread overview]
Message-ID: <1181220656.4187.64.camel@gaivota> (raw)
In-Reply-To: <Pine.LNX.4.64.0706062106150.30244@anakin>

Hi Geert,

Em Qua, 2007-06-06 às 21:11 +0200, Geert Uytterhoeven escreveu:
> 	Hi,
> 
> drivers/media/dvb/b2c2/flexcop-dma.c uses the PCI DMA API, but DVB_B2C2_FLEXCOP
> doesn't depend on PCI, causing the following problem on PCI-less systems:
> 
> | linux/drivers/media/dvb/b2c2/flexcop-dma.c:20: warning: implicit declaration of function 'pci_alloc_consistent'
> | linux/drivers/media/dvb/b2c2/flexcop-dma.c:20: warning: implicit declaration of function 'pci_alloc_consistent'
> 
> Apparently this is the flexcop DMA core, which is used by both
> DVB_B2C2_FLEXCOP_PCI and DVB_B2C2_FLEXCOP_USB.
> 
> DVB_B2C2_FLEXCOP_PCI depends on PCI.
> DVB_B2C2_FLEXCOP_USB depends on USB.

Thanks for pointing us about this issue. While the usage of the generic
dma is the better way, a simple fix can be applied by simply moving
flexcop-dma to b2c2-flexcop-pci (currently, only the last uses the DMA
stuff). I've committed such patch. It is available at:

http://linuxtv.org/hg/v4l-dvb/rev/c314ec17335a

 
Cheers,
Mauro


  reply	other threads:[~2007-06-07 12:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06 19:11 drivers/media/dvb/b2c2/flexcop-dma.c uses PCI DMA API Geert Uytterhoeven
2007-06-07 12:50 ` Mauro Carvalho Chehab [this message]
2007-06-07 14:03   ` [v4l-dvb-maintainer] " Michael Krufky
2007-06-07 14:10     ` Mauro Carvalho Chehab
2007-06-07 20:41       ` Trent Piepho
2007-06-08 12:30         ` Mauro Carvalho Chehab
2007-06-08 18:18           ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181220656.4187.64.camel@gaivota \
    --to=mchehab@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-dvb@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox