public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Krzysztof Halasa <khc@pm.waw.pl>,
	Alistair John Strachan <s0348365@sms.ed.ac.uk>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist
Date: Fri, 08 Jun 2007 12:11:53 +0200	[thread overview]
Message-ID: <1181297513.7348.287.camel@twins> (raw)
In-Reply-To: <20070608012534.GB23290@havoc.gtf.org>

On Thu, 2007-06-07 at 21:25 -0400, Jeff Garzik wrote:
> On Thu, Jun 07, 2007 at 06:08:32PM -0700, H. Peter Anvin wrote:
> > My big concern with the 80-column rule is that it discourages commenting.
> 
> My concern with that logic is that encourages random, super-wide code
> lines that varies with each coder.  You are left to the mercy of he with
> the widest text window.

I just counted, I can get 380 chars on 1 screen, if I let it straddle
the two monitors I have then I can get 760 chars.

> The 80-column rule is good as a general guideline, though there are
> obvious exceptions.  Comments IMO are not one of them.  That rapidly
> creates unreadable code.

I agree, its easier on the eyes to have dense columns of text to read
than having to scan all over the place. More so, its more economical of
screen-estate as well, a few long lines take up valuable space which
could otherwise have been used to create more columns (yes, from the guy
sitting behind the two 24" screen).

I usually work with 4 columns side by side per screen, that gives me
about 92x110 columns. Its easy on they eye (it need not wander all over
the place to read stuff) and it can handle the occasional line that
exceeds 80 chars (they never exceed very far - yes there are
exceptions :-( )




  reply	other threads:[~2007-06-08 10:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-07 15:22 [PATCH] intel-rng: Undo mess made by an 80 column extremist Alan Cox
2007-06-07 15:23 ` Jeff Garzik
2007-06-07 15:44   ` Alan Cox
2007-06-07 17:22     ` Jeff Garzik
2007-06-07 21:17 ` Krzysztof Halasa
2007-06-07 21:32   ` Alistair John Strachan
2007-06-07 22:06     ` Krzysztof Halasa
2007-06-08  1:08       ` H. Peter Anvin
2007-06-08  1:25         ` Jeff Garzik
2007-06-08 10:11           ` Peter Zijlstra [this message]
2007-06-09 20:33             ` Krzysztof Halasa
2007-06-07 22:32   ` Daniel Hazelton
2007-06-07 22:37     ` Krzysztof Halasa
2007-06-07 23:01       ` Daniel Hazelton
2007-06-07 22:46     ` Jesper Juhl
2007-06-07 23:04       ` Daniel Hazelton
2007-06-08  1:44   ` John Stoffel
2007-06-08  1:47     ` Jeff Garzik
2007-06-08  1:56       ` John Stoffel
2007-06-08  2:07         ` Jeff Garzik
2007-06-08  2:11           ` John Stoffel
2007-06-08 18:21             ` Ingo Oeser
2007-06-09 20:41         ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181297513.7348.287.camel@twins \
    --to=peterz@infradead.org \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=jeff@garzik.org \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s0348365@sms.ed.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox