The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: Michael Krufky <mkrufky@linuxtv.org>,
	linux-dvb@linuxtv.org, v4l-dvb-maintainer@linuxtv.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [v4l-dvb-maintainer] drivers/media/dvb/b2c2/flexcop-dma.c uses PCI DMA API
Date: Fri, 08 Jun 2007 09:30:20 -0300	[thread overview]
Message-ID: <1181305820.3877.52.camel@gaivota> (raw)
In-Reply-To: <Pine.LNX.4.58.0706071147080.9347@shell2.speakeasy.net>

Hi Trent,

> Here is a patch that does just option B.  I have a couple other
> patches too.

Tracking the flexcop, I've arrived on a similar patch to yours, but this
approach will duplicate some debug macros. This is somewhat ugly. Since
we need this fix for a late -rc, I think that the better for now is to
use an optional code on Makefile that will add flexcop-dma to
b2c2-flexcop only if flexcop pci support is selected. The end result is
very simple, and will solve the issue.

The final patch is this one:
http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=ee9a55464446146acbe12556d6de12cad0ac18c7
 
Cheers,
Mauro


  reply	other threads:[~2007-06-08 12:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06 19:11 drivers/media/dvb/b2c2/flexcop-dma.c uses PCI DMA API Geert Uytterhoeven
2007-06-07 12:50 ` Mauro Carvalho Chehab
2007-06-07 14:03   ` [v4l-dvb-maintainer] " Michael Krufky
2007-06-07 14:10     ` Mauro Carvalho Chehab
2007-06-07 20:41       ` Trent Piepho
2007-06-08 12:30         ` Mauro Carvalho Chehab [this message]
2007-06-08 18:18           ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181305820.3877.52.camel@gaivota \
    --to=mchehab@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-dvb@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox