From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Fengguang Wu <wfg@mail.ustc.edu.cn>
Subject: Re: [PATCH 2/2] readahead: sanify file_ra_state names
Date: Fri, 15 Jun 2007 14:38:07 +1000 [thread overview]
Message-ID: <1181882288.6237.205.camel@localhost.localdomain> (raw)
In-Reply-To: <20070614062816.085421580@mail.ustc.edu.cn>
On Thu, 2007-06-14 at 14:21 +0800, Fengguang Wu wrote:
> plain text document attachment (readahead-rename.patch)
> Rename some file_ra_state variables and remove some accessors.
>
> It results in much simpler code.
> Kudos to Rusty!
>
> Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
Needless to say, I'm now very satisfied with the new readahead code.
That's not to say there won't be corner cases where the old code did
better, but given the replacement's simplicity and Fengguang's positive
benchmark results I really like it.
Thanks for Fengguang for coding and pushing this!
Rusty.
next prev parent reply other threads:[~2007-06-15 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070614062447.058708836@mail.ustc.edu.cn>
2007-06-14 6:21 ` [PATCH 0/2] ondemand readahead simplifications Fengguang Wu
[not found] ` <20070614062815.949361167@mail.ustc.edu.cn>
2007-06-14 6:21 ` [PATCH 1/2] readahead: split ondemand readahead interface into two functions Fengguang Wu
[not found] ` <20070614062816.085421580@mail.ustc.edu.cn>
2007-06-14 6:21 ` [PATCH 2/2] readahead: sanify file_ra_state names Fengguang Wu
2007-06-15 4:38 ` Rusty Russell [this message]
[not found] <20070613134902.132573123@mail.ustc.edu.cn>
[not found] ` <20070613135128.282288719@mail.ustc.edu.cn>
2007-06-13 13:49 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181882288.6237.205.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox