From: Steven Rostedt <rostedt@goodmis.org>
To: Ralph Campbell <ralph.campbell@qlogic.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Roland Dreier <rdreier@cisco.com>,
openib-general@openib.org, Oleg Nesterov <oleg@tv-sign.ru>,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [POSSIBLE BUG] use of tasklet_unlock in ipath_no_bufs_available
Date: Mon, 25 Jun 2007 16:49:08 -0400 [thread overview]
Message-ID: <1182804548.5493.216.camel@localhost.localdomain> (raw)
In-Reply-To: <1182803821.18911.237.camel@brick.pathscale.com>
On Mon, 2007-06-25 at 13:37 -0700, Ralph Campbell wrote:
> This was fixed by a patch that Arthur Jones sent out to
> general@lists.openfabrics.org
Great!
>
> Tue Jun 19 16:42:09 PDT 2007
> [PATCH 17/28] IB/ipath - wait for PIO available interrupt
>
> I imagine that it is working its way into Roland's git tree
> for Linus.
* tasklet_hi_schedule() is called.
- * We clear the tasklet flag now since we are committing to return
- * from the tasklet function.
+ * We leave the busy flag set so that another post send doesn't
+ * try to put the same QP on the piowait list again.
*/
- clear_bit(IPATH_S_BUSY, &qp->s_busy);
- tasklet_unlock(&qp->s_task);
want_buffer(dev->dd);
dev->n_piowait++;
This removes the final use of tasklet_unlock. I'll submit a patch to
remove this from being a public function. So no others think they can
easily get to the internals of a tasklet.
-- Steve
prev parent reply other threads:[~2007-06-25 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 19:33 [POSSIBLE BUG] use of tasklet_unlock in ipath_no_bufs_available Steven Rostedt
2007-06-25 20:37 ` [ofa-general] " Ralph Campbell
2007-06-25 20:49 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1182804548.5493.216.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=openib-general@openib.org \
--cc=ralph.campbell@qlogic.com \
--cc=rdreier@cisco.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox