public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Matt Mackall <mpm@selenic.com>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@xensource.com>
Subject: [PATCH] Fix lguest w/ lockdep
Date: Thu, 28 Jun 2007 23:31:59 +1000	[thread overview]
Message-ID: <1183037519.6211.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20070628001425.GR11115@waste.org>

On Wed, 2007-06-27 at 19:14 -0500, Matt Mackall wrote:
> lguest: unhandled trap 14 at 0xc01362f7 (0x0)
> Dump of assembler code for function __lock_acquire:

Thanks for the bug report Matt!  I wonder if other
paravirt_disable_iospace users have the same issue...
===

Fix "lguest: unhandled trap 14 at 0xc013630f (0x0)" with CONFIG_LOCKDEP=y

paravirt_disable_iospace -> request_resource -> write_lock -> __lock_acquire()

lockdep_init() is already idempotent: simply call it before
paravirt_disable_iospace().

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff -r bea2b8147985 drivers/lguest/lguest.c
--- a/drivers/lguest/lguest.c	Thu Jun 07 22:50:36 2007 +1000
+++ b/drivers/lguest/lguest.c	Thu Jun 28 23:21:26 2007 +1000
@@ -593,6 +593,8 @@ __init void lguest_init(void *boot)
 
 	reserve_top_address(lguest_data.reserve_mem);
 
+	lockdep_init();
+
 	paravirt_disable_iospace();
 
 	cpu_detect(&new_cpu_data);



       reply	other threads:[~2007-06-28 13:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070628001425.GR11115@waste.org>
2007-06-28 13:31 ` Rusty Russell [this message]
2007-06-28 13:51   ` [PATCH] Fix lguest w/ lockdep Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1183037519.6211.2.camel@localhost.localdomain \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=jeremy@xensource.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox