From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424041AbcFMTJ3 (ORCPT ); Mon, 13 Jun 2016 15:09:29 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52144 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1423247AbcFMTJX (ORCPT ); Mon, 13 Jun 2016 15:09:23 -0400 X-IBM-Helo: d24dlp02.br.ibm.com X-IBM-MailFrom: bauerman@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: Thiago Jung Bauermann To: Dave Young Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Biederman Subject: Re: [PATCH 2/8] kexec_file: Generalize kexec_add_buffer. Date: Mon, 13 Jun 2016 16:08:19 -0300 User-Agent: KMail/4.14.3 (Linux/3.13.0-87-generic; KDE/4.14.13; x86_64; ; ) In-Reply-To: <20160613072939.GD4974@dhcp-128-65.nay.redhat.com> References: <1465701022-11601-1-git-send-email-bauerman@linux.vnet.ibm.com> <1465701022-11601-3-git-send-email-bauerman@linux.vnet.ibm.com> <20160613072939.GD4974@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061319-0020-0000-0000-0000021261D5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061319-0021-0000-0000-00002FE46157 Message-Id: <11831785.bAnhpkoBlL@hactar> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-13_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606130211 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Dave, Thanks for the quick review and for your comments. I'll separate the change to add arch_walk_system_ram and the change to add kexec_locate_mem_hole into different patches, and add error handling for KEXEC_ON_CRASH. Am Montag, 13 Juni 2016, 15:29:39 schrieb Dave Young: > On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > > Allow architectures to specify different memory walking functions for > > kexec_add_buffer. Intel uses iomem to track reserved memory ranges, > > but PowerPC uses the memblock subsystem. > > Can the crashk_res be inserted to iomem_resource so that only one > weak function for system ram is needed? Sorry, it's not clear to me what you mean by inserting crashk_res into iomem_resource, but I can add a bool for_crashkernel to arch_walk_system_ram so that it can decide which kind of memory to traverse, so the default implementation of kexec_file.c would be: int __weak arch_walk_system_ram(bool for_crashkernel, unsigned long start, unsigned long end, bool top_down, void *data, int (*func)(u64, u64, void *)) { int ret; if (for_crashkernel) ret = walk_iomem_res_desc(crashk_res.desc, IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY, start, end, data, func); else ret = walk_system_ram_res(start, end, data, func); if (ret != 1) { /* A suitable memory range could not be found for buffer */ return -EADDRNOTAVAIL; } } and kexec_add_buffer / kexec_locate_mem_hole would call it with: if (image->type == KEXEC_TYPE_CRASH) ret = arch_walk_system_ram(true, crashk_res.start, crashk_res.end, top_down, &buf, locate_mem_hole_callback); else ret = arch_walk_system_ram(false, 0, -1, top_down, &buf, locate_mem_hole_callback); What do you think? -- []'s Thiago Jung Bauermann IBM Linux Technology Center