public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Gabriel C <nix.or.die@googlemail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org
Subject: Re: [SCSI] SD driver question
Date: Thu, 05 Jul 2007 15:37:46 -0500	[thread overview]
Message-ID: <1183667866.3448.61.camel@localhost.localdomain> (raw)
In-Reply-To: <468BCE5C.6000707@googlemail.com>

On Wed, 2007-07-04 at 18:44 +0200, Gabriel C wrote: 
> Is there any reason why sd is printing the driver informations for each 
> disk twice in dmesg ?

Yes, it's because of the genhd revalidate rework done by Al Viro in the
block device revalidation path.  The problem is that we need to run a
disk revalidate early on in sd bringup to get all the necessary
information ... the gendisk code then does a disk revalidate to read the
partition table, resulting in the two identical sets of messages being
printed.  The best fix anyone could suggest was to try to suppress the
messages of the first one using some sort of per scsi_disk flag ...
however, no-one's very keen on this approach.

James



      parent reply	other threads:[~2007-07-05 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04 16:44 [SCSI] SD driver question Gabriel C
2007-07-04 16:56 ` Uwe Kiewel
2007-07-04 17:29   ` Gabriel C
2007-07-05 17:36     ` Uwe Kiewel
2007-07-05 20:37 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1183667866.3448.61.camel@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nix.or.die@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox