From: James Bottomley <James.Bottomley@SteelEye.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
akpm@linux-foundation.org, jeff@garzik.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/3] clean gendisk out of scsi ULD structs
Date: Thu, 05 Jul 2007 18:14:06 -0500 [thread overview]
Message-ID: <1183677246.3448.71.camel@localhost.localdomain> (raw)
In-Reply-To: <20070705230251.GS21478@ftp.linux.org.uk>
On Fri, 2007-07-06 at 00:02 +0100, Al Viro wrote:
> On Thu, Jul 05, 2007 at 02:06:36PM -0700, Kristen Carlson Accardi wrote:
> > Since gendisk will now become part of struct scsi_device, we don't need
> > to store this value in any private data structs where they already store
> > scsi_device. This series cleans up a few drivers which did this.
>
> What the hell? gendisks are *NOT* supposed to be embedded into other
> data structures, you'll screw up the lifetime rules for them.
Don't panic .. they're not ... we have a pointer to the gendisk in our
SCSI structures (properly refcounted). The reason is historical and
actually goes back to 2002 when we first got rid of the static arrays of
structures we used to keep around.
Doug ... don't think 'disk' when you see 'gendisk' just think of it as a
useful infrastructure library.
James
next prev parent reply other threads:[~2007-07-05 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 21:06 [patch 0/3] clean gendisk out of scsi ULD structs Kristen Carlson Accardi
2007-07-05 22:09 ` Douglas Gilbert
2007-07-05 23:03 ` Al Viro
2007-07-05 23:02 ` Al Viro
2007-07-05 23:14 ` James Bottomley [this message]
2007-07-06 20:02 ` James Bottomley
2007-07-07 3:25 ` Douglas Gilbert
2007-07-07 15:15 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183677246.3448.71.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox