Re: [PATCH] Remove process freezer from suspend to RAM pathway

Alan Stern
2007-07-08T02:24:22Z

On Sun, 8 Jul 2007, Benjamin Herrenschmidt wrote:

> > Which is exactly my point. It _doesn't_ work fine without a freezer,
> > because the USB stack currently relies on the freezer to prevent plug
> > activity.
>
> Putting on hold plug activity has nothing, NOTHING, to do with the half
> assed piece of deadlocking crap we have now we call a freezer.

You're wrong; it _does_ have something to do with the freezer. The
connection is that the code uses the freezer to put plug activity on
hold.

You probably meant to say that it _should_ have nothing to do with the
freezer. That's a different matter. But in any case you should write
what you actually mean, rather than just putting down something as
inflammatory as possible.

> As long as you guys keep mixing up all the issues and coming up with
> totally bogus solutions that cannot work, we won't have a useful suspend
> (either to RAM or to disk) in linux.

In my defense, you should realize that until Rafael's notifier chain
was added (just a few weeks ago, still not in mainline I believe) there
was no other way to do it. Plug activity needs to be stopped before
the child devices are suspended, and the PM core does not send any
notification to drivers at that time. All it does is activate the
freezer.

Alan Stern