Re: [PATCH] Remove process freezer from suspend to RAM pathway

Benjamin Herrenschmidt
2007-07-03T21:17:18Z

On Tue, 2007-07-03 at 15:08 +0200, Rafael J. Wysocki wrote:
> On Tuesday, 3 July 2007 07:51, Benjamin Herrenschmidt wrote:
> > On Tue, 2007-07-03 at 05:29 +0100, Matthew Garrett wrote:
> > > Suspend to RAM on a machine with / on a fuse filesystem turns out to be
> > > a screaming nightmare - either the suspend fails because syslog (for
> > > instance) can't be frozen, or the machine deadlocks for some other
> > > reason I haven't tracked down. We could "fix" fuse, or alternatively we
> > > could do what we do for suspend to RAM on other platforms (PPC and APM)
> > > and just not use the freezer.
> >
> > The main reason for deadlocks is because we do a sys_sync() after the
> > freeze, which we shouldn't do.
>
> So why don't we remove the sys_sync() from freeze_processes() instead?

Or rather, move it to before freeze_processes() so that you get at least
some level of sync'ing just in case you never wake up. Not perfect
(things may still get dirty) but it will help the immediate issue.

Ben.