Re: [PATCH] Remove process freezer from suspend to RAM pathway

Pavel Machek
2007-07-07T11:56:00Z

Hi!

> > > And guess what ? It's what we do on powerbooks, and it works fine,
> > > without a freezer :-)

Well, issue is, you should stop claiming it works fine until issue
below is fixed... please?

And anyway I believe that current issue (fuse deadlocks with s2ram)
should be present on powerbooks, too... it is just way harder to
trigger. All that is neccessary is fused (or one of its helpers) to
get frozen by accessing suspended device.

Pavel

> > I wish you'd stop saying that. Have you ever done any serious testing?
> >
> > Here's something to try: Add a time delay to the end of hub_suspend in
> > drivers/usb/core/hub.c, so you can provoke a race manually. Then while
> > one of your root hubs is being suspended and the system is waiting in
> > that delay, either plug in a new USB device to that hub or unplug an
> > existing device.
> >
> > Be sure that CONFIG_USB_DEBUG is on so that we can figure out what
> > happened after the fact.
>
> If you remember, one of the things I've been advocating has always been
> that we should put on hold all plug activity (unplug might be alright as
> long as the user events are just delayed) when we start suspending. No
> new devices, no new bindings. "hub" type devices are respondible for
> bringing in the new stuff after resume.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html