Re: [kvm-devel] [PATCH][RFC] kvm-scheduler integration

[Rusty Russell <rusty@rustcorp.com.au>]

On Mon, 2007-07-09 at 09:39 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> > I think a "struct preempt_ops *" and a "void *preempt_ops_data" inside
> > every task struct is a better idea.  Call the config option
> > PREEMPT_SCHED_HOOKS and now there's nothing kvm-specific about it...
> >   
> 
> I considered that, but your proposal does not allow a single task to
> have multiple preemption hooks installed (hookers?!).  Since in general
> there's no reason to suppose that users would be mutually exclusive, we
> need to have a struct hlist of these things.  All in all this seemed to
> indicate that the second user should have the honor of figuring out that
> stuff.

No; this is a "I'm doing something magic and need to know before someone
else takes the CPU".  Almost by definition, you cannot have two of them
at the same time.  Let someone else try that if and when...

But having different hooks for different tasks makes a great deal of
sense.  This hook makes a great deal of sense.

But KVM-specific code in the scheduler is just wrong, and I think we all
know that.

Cheers,
Rusty.