From: Rusty Russell <rusty@rustcorp.com.au>
To: Matt Mackall <mpm@selenic.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: maps2-move-the-page-walker-code-to-lib.patch
Date: Tue, 10 Jul 2007 12:06:35 +1000 [thread overview]
Message-ID: <1184033195.6005.439.camel@localhost.localdomain> (raw)
In-Reply-To: <20070709202217.GS11115@waste.org>
On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote:
> On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote:
> > Matt wrote:
> > > This lets it get shared outside of proc/ and linked in only when needed.
> >
> > Erk, this really belongs in the mm dir. You can use "lib-y +=
> > pagewalk.o" there, and it seems to work as well as doing it in lib.
>
> Are you sure? I tested that a few months ago and it didn't work for
> me. I seem to recall it wanted a chunk of makefile surgery.
Well, I tested here and it worked unless I screwed something (producing
lib.a in mm/ and linking it in). And when I turned off all the CONFIG
options which required it, the symbols disappeared from the vmlinux...
Rusty.
next prev parent reply other threads:[~2007-07-10 2:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 5:49 maps2-move-the-page-walker-code-to-lib.patch Rusty Russell
2007-07-08 9:46 ` maps2-move-the-page-walker-code-to-lib.patch Nick Piggin
2007-07-09 20:22 ` maps2-move-the-page-walker-code-to-lib.patch Matt Mackall
2007-07-10 2:06 ` Rusty Russell [this message]
2007-07-13 20:48 ` maps2-move-the-page-walker-code-to-lib.patch Sam Ravnborg
2007-07-17 1:09 ` maps2-move-the-page-walker-code-to-lib.patch Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184033195.6005.439.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=rientjes@google.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox