From: Artem Bityutskiy <dedekind@infradead.org>
To: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBI: cleanup usage of try_module_get
Date: Wed, 11 Jul 2007 12:17:51 +0300 [thread overview]
Message-ID: <1184145471.3531.88.camel@sauron> (raw)
In-Reply-To: <1184141505.4608.29.camel@sebastian.kern.oss.ntt.co.jp>
On Wed, 2007-07-11 at 17:11 +0900, Fernando Luis Vázquez Cao wrote:
> The use of try_module_get(THIS_MODULE) in ubi_get_device_info does not
> offer real protection against unexpected driver unloads, since we could
> be preempted before try_modules_get gets executed. It is the caller who
> should manipulate the refcounts. Besides, ubi_get_device_info is an
> exported symbol which guarantees protection when accessed through
> symbol_get.
Yeah, looks fair, committed to UBI git, thanks.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2007-07-11 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 7:55 [PATCH RFC] try_module_get usage Fernando Luis Vázquez Cao
2007-07-11 8:11 ` [PATCH] UBI: cleanup usage of try_module_get Fernando Luis Vázquez Cao
2007-07-11 9:17 ` Artem Bityutskiy [this message]
2007-07-11 9:41 ` [PATCH RFC] try_module_get usage Christoph Hellwig
2007-07-11 10:01 ` Artem Bityutskiy
2007-07-11 10:18 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184145471.3531.88.camel@sauron \
--to=dedekind@infradead.org \
--cc=fernando@oss.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox