From: Rusty Russell <rusty@rustcorp.com.au>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>,
shaohua.li@intel.com
Subject: Re: [PATCH 1/2] SCHED: Generic hooks for trapping task preemption
Date: Thu, 12 Jul 2007 12:56:58 +1000 [thread overview]
Message-ID: <1184209018.6005.706.camel@localhost.localdomain> (raw)
In-Reply-To: <11841693333159-git-send-email-avi@qumranet.com>
On Wed, 2007-07-11 at 18:55 +0300, Avi Kivity wrote:
> +config PREEMPT_HOOKS
> + bool
> + depends on X86
> + default y
Hmm, I would have thought that having CONFIG_KVM "select PREEMPT_HOOKS"
would be a little clearer.
> +static void fire_sched_in_preempt_hooks(struct task_struct *tsk)
> +{
> + struct preempt_hook *hook;
> + struct hlist_node *node;
> +
> + hlist_for_each_entry(hook, node, &tsk->preempt_hooks, link)
> + hook->ops->sched_in(hook, raw_smp_processor_id());
> +}
The old current/tsk conflation. You hand in "tsk" here, but since
that's not handed through to the sched_in, it must be "current". It's
just unfortunate that this generates better code...
But patch looks good.
Cheers,
Rusty.
next prev parent reply other threads:[~2007-07-12 2:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 15:55 [PATCH 0/2][RFC] Scheduler preemption hooks, #2 Avi Kivity
2007-07-11 15:55 ` [PATCH 1/2] SCHED: Generic hooks for trapping task preemption Avi Kivity
2007-07-12 2:56 ` Rusty Russell [this message]
2007-07-12 5:14 ` Rusty Russell
2007-07-12 5:48 ` Avi Kivity
2007-07-11 15:55 ` [PATCH 2/2] KVM: Use the scheduler preemption hooks to make kvm preemptible Avi Kivity
2007-07-11 20:10 ` [kvm-devel] " Luca
2007-07-12 5:43 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184209018.6005.706.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox