Re: [patch 0/4] Cell SPE logos

Geert Uytterhoeven
2007-07-13T08:52:24Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1966 bytes --]

On Thu, 12 Jul 2007, Andrew Morton wrote:
> On Tue, 10 Jul 2007 14:27:02 +0200
> Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
>
> > The Cell Broadband Engine contains a 64-bit PowerPC core with 2 hardware
> > threads (called PPEs) and 8 Synergistic Processing Engines (called SPEs).
> > When booting Linux, 2 penguins logos are shown on the graphical console by
> > the standard frame buffer console logo code.
> >
> > To emphasize the existence of the SPEs (which can be used under Linux), we
> > added a second row of (smaller) helper penguin logos, one for each SPE.
> >
> > A sample screenshot can be found at
> > http://www.kernel.org/pub/linux/kernel/people/geoff/cell/debian-penguin-shot.png
> > (or on the ps3linux T-shirts we wore at OLS :-)
>
> Does this mean I'll get penguins on my PS3 now?

Sure!

> > Summaries:
> > [1] fbdev: extract fb_show_logo_line()
> > [2] fbdev: Add fb_append_extra_logo()
>
> This one does give additional code and data to all fbdev users while only
> being useful to cell machines. Should we fix that?

I can protect it by #ifdef CONFIG_PPC_CELL (as long as there are no other
users). Would that be OK?

> > [3] fbdev: SPE helper penguin logo
> > [4] Cell: Draw SPE helper penguin logos
>
> I queued #4 up along with the fbdev patches, even though it isn't really an
> fbdev patch.

OK, thanks!