Re: [patch 0/4] Cell SPE logos

Geert Uytterhoeven
2007-07-13T09:10:00Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1323 bytes --]

On Fri, 13 Jul 2007, Andrew Morton wrote:
> On Fri, 13 Jul 2007 10:52:10 +0200 (CEST) Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
>
> > > > Summaries:
> > > > [1] fbdev: extract fb_show_logo_line()
> > > > [2] fbdev: Add fb_append_extra_logo()
> > >
> > > This one does give additional code and data to all fbdev users while only
> > > being useful to cell machines. Should we fix that?
> >
> > I can protect it by #ifdef CONFIG_PPC_CELL (as long as there are no other
> > users). Would that be OK?
>
> umm, your call. If that makes sense, sure.

I just don't like putting platform-specific checks in common code.

Perhaps I better add CONFIG_FB_LOGO_EXTRA and make it depend on
CONFIG_PPC_CELL?