From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Steven Rostedt <rostedt@goodmis.org>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH -rt 1/5] workqueue: queue_work_cpu
Date: Sat, 14 Jul 2007 20:00:46 +0200 [thread overview]
Message-ID: <1184436047.5284.60.camel@lappy> (raw)
In-Reply-To: <20070714171406.GA746@tv-sign.ru>
On Sat, 2007-07-14 at 21:14 +0400, Oleg Nesterov wrote:
> On 07/14, Peter Zijlstra wrote:
> >
> > +int fastcall queue_work_cpu(struct workqueue_struct *wq, struct work_struct *work, int cpu)
> > +{
> > + int ret = 0;
> > +
> > + if (!test_and_set_bit(WORK_STRUCT_PENDING, work_data_bits(work))) {
> > + BUG_ON(!list_empty(&work->entry));
> > + __queue_work(wq_per_cpu(wq, cpu), work);
> > + ret = 1;
> > + }
> > + return ret;
> > +}
>
> Minor nit, we already have queue_delayed_work_on(), perhaps it should be named
> queue_work_on().
Yes, that makes sense. Shall do.
next prev parent reply other threads:[~2007-07-14 18:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 17:57 [PATCH -rt 0/5] making SLUB -rt friendly Peter Zijlstra
2007-07-14 17:57 ` [PATCH -rt 1/5] workqueue: queue_work_cpu Peter Zijlstra
2007-07-14 17:14 ` Oleg Nesterov
2007-07-14 18:00 ` Peter Zijlstra [this message]
2007-07-14 17:57 ` [PATCH -rt 2/5] Thread Migration Preemption - v2 Peter Zijlstra
2007-07-14 16:49 ` Mathieu Desnoyers
2007-07-14 17:16 ` Oleg Nesterov
2007-07-14 17:34 ` Peter Zijlstra
2007-07-14 18:44 ` Peter Zijlstra
2007-07-14 19:07 ` Peter Zijlstra
2007-07-14 20:39 ` Mathieu Desnoyers
2007-07-14 20:48 ` Oleg Nesterov
2007-07-14 20:53 ` Peter Zijlstra
2007-07-14 17:57 ` [PATCH -rt 3/5] asm/local.h cmpxchg Peter Zijlstra
2007-07-14 16:52 ` Daniel Walker
2007-07-14 17:14 ` Mathieu Desnoyers
2007-07-14 17:31 ` Peter Zijlstra
2007-07-14 18:33 ` Mathieu Desnoyers
2007-07-14 17:57 ` [PATCH -rt 4/5] use migrate_disable for __local_begin Peter Zijlstra
2007-07-14 17:16 ` Mathieu Desnoyers
2007-07-14 17:32 ` Peter Zijlstra
2007-07-14 18:35 ` Mathieu Desnoyers
2007-07-14 18:41 ` Peter Zijlstra
2007-07-14 18:52 ` Mathieu Desnoyers
2007-07-14 17:57 ` [PATCH -rt 5/5] slub: -rt port Peter Zijlstra
2007-07-14 17:39 ` Oleg Nesterov
2007-07-14 17:50 ` Peter Zijlstra
2007-07-14 19:38 ` Oleg Nesterov
2007-07-14 19:49 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184436047.5284.60.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox