From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754354AbcGVNaU (ORCPT ); Fri, 22 Jul 2016 09:30:20 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:49648 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754295AbcGVNaR (ORCPT ); Fri, 22 Jul 2016 09:30:17 -0400 From: Arnd Bergmann To: Mark Rutland Cc: Tan Xiaojun , robh+dt@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, xuwei5@hisilicon.com, devicetree@vger.kernel.org, khilman@linaro.org, k.kozlowski@samsung.com, amitdanielk@gmail.com, heiko@sntech.de, wxt@rock-chips.com, alex.aring@gmail.com, qiang.zhao@freescale.com, treding@nvidia.com, rmk+kernel@arm.linux.org.uk, gregory.clement@free-electrons.com, f.fainelli@gmail.com, geert+renesas@glider.be, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Date: Fri, 22 Jul 2016 15:27:04 +0200 Message-ID: <11848764.OZ77lJYCM4@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160722105648.GD17584@leverpostej> References: <1469177332-72156-1-git-send-email-tanxiaojun@huawei.com> <20160722105648.GD17584@leverpostej> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:AmwQ6e+/CWORc3SmNvRbJ71mQREB9VQ1JL7edjAp09x/F3pHS6P bgarT9+p8vtDKtEmAz+grSAWZWcaR2Gcw9LHCg1MEimlz3Vdk7ib7bEzX8zGVmNswbrucf8 xi6zdrvkumwLCV/4Hb+dkZInT4XiH0umqzOkCr47owncPVKOOXKP06wqyPZ98YPUIkEQRum QZLcdCs8f5Z4QCZuqoILw== X-UI-Out-Filterresults: notjunk:1;V01:K0:uDZjYyhLLcg=:HjkSDtA1ZzpPNvhBdsctdC 54nr1IuVv2vhOcwsScXEFeGU85Kev3CprHsCIP6pG9HD1M5bfkHHvl+NghEYbEFUP8aLFIdCP oStQ/Jr1Tp8FSuENm58uBpyonOvQ8ElHJor9pZ1BCVo+lzOqsdMRN3EbiW5sn7ytnxrfgKUXW /wv76ZGNGwOj8PKS6NAaJh2t0MV881yPHaPIOIa1VtuUdcO8unyBUSEcl9pXtqezLGCdaJ2Yj oJyOOCxPGdSoxCJgzqzP3i85JGIPNF71alGL4okF72n0fV05fPF7WUPEAXJo1i1nY6xdtN7YM xj6181UQhuiXZQpFhagfsHZJLj8KCJ4ZAC+nkJtpuqS3Jeo/0o/cRe8s9HfkwaAgfMq9V6bqf mVUkbfbCMj5k0BuRdefMIRR3JCf7eS3/fFVojlkPjv1m5md5EcPWqVnUnx+TF8MiKsjg06qwQ Mrp0Vux1kfNwlsZlOZXZ51SkXEo0vxgQp4J6LFVPOhrgyerXSwPCsYv/DWMamTdn9P/Onpfj0 OErP3DJc+eiBstYzsQZvMJWzA2gxyRsPSD8mG3kg9JZdsYklFP/9p/dcRAG8A9r1rFxIcmvum pOSSvMh7QR2g630j9gcHcGO92iQyXi02q516PRjLuFtKY9Uzm0xnCnU4rwZ4h416YaQ/Su+BE Eknu9RNMPhDBx52q6LRSTLkvIGyvCeTFFneLy0bCiwl7h8f9hj0+TIyPWNXSEEoQPz1CtiQLx dgX3ZnT4CkOUJZ2Y Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 22, 2016 11:56:49 AM CEST Mark Rutland wrote: > Hi, > > I understand that some SoC/socket level PMU is accessed via these > registers. It doesn't make sense to review either in isolation. Please > put together a unified series, with both the djtag accessors and the > PMU code. > > On it's own, it's *very* difficult to understand how this fits into the > SoC, and how it is to be used. Is there anything else that the driver is used for? Having it in drivers/soc/ feels wrong to me, and if there is only one user, I'd recommend having it as part of the same driver module as the code accessing it. Arnd