Re: Problems with framebuffer in 2.6.22-git17

Antonino A. Daplas
2007-07-27T21:43:35Z

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

On Fri, 2007-07-27 at 20:47 +0100, Adrian McMenamin wrote:
> On 26/07/07, Antonino A. Daplas <adaplas@gmail.com> wrote:
>
> >
> > I'm also confused. Can you change the color depth to 32 bpp ('fbset
> > -depth 32')? I'm thinking of a possible pseudo_palette overrun.
> >
>
> The code behaves in exactly the same way with the bit depth set to 32
> and without the patch reversion (ie forces a reboot).
>
> With the parch reverted there is a flicker of output on the screen
> before a reboot is forced (it will boot with 16bpp though the colour
> is a bit iffy)
>
> With the patch reverted and 24bpp, it oopses before freezing (with two
> odd looking boot logos on the screen):

Can you try the attached patch? It's just a clean-up patch: uses
framebuffer_alloc/release instead of kmalloc.

Tony

[-- Attachment #2: pvr2_cleanup.diff --]
[-- Type: text/x-patch, Size: 1638 bytes --]

diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c
index f930026..a72921b 100644
--- a/drivers/video/pvr2fb.c
+++ b/drivers/video/pvr2fb.c
@@ -143,6 +143,7 @@ static struct pvr2fb_par {
unsigned char is_lowres; /* Is horizontal pixel-doubling enabled? */

unsigned long mmio_base; /* MMIO base */
+ u32 palette[16];
} *currentpar;

static struct fb_info *fb_info;
@@ -790,7 +791,7 @@ static int __devinit pvr2fb_common_init(
fb_info->fbops = &pvr2fb_ops;
fb_info->fix = pvr2_fix;
fb_info->par = currentpar;
- fb_info->pseudo_palette = (void *)(fb_info->par + 1);
+ fb_info->pseudo_palette = currentpar->palette;
fb_info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;

if (video_output == VO_VGA)
@@ -1082,14 +1083,15 @@ #ifndef MODULE
#endif
size = sizeof(struct fb_info) + sizeof(struct pvr2fb_par) + 16 * sizeof(u32);

- fb_info = kzalloc(size, GFP_KERNEL);
+ fb_info = framebuffer_alloc(sizeof(struct pvr2fb_par), NULL);
+
if (!fb_info) {
printk(KERN_ERR "Failed to allocate memory for fb_info\n");
return -ENOMEM;
}

- currentpar = (struct pvr2fb_par *)(fb_info + 1);
+ currentpar = fb_info->par;

for (i = 0; i < ARRAY_SIZE(board_driver); i++) {
struct pvr2_board *pvr_board = board_driver + i;
@@ -1102,7 +1104,7 @@ #endif
if (ret != 0) {
printk(KERN_ERR "pvr2fb: Failed init of %s device\n",
pvr_board->name);
- kfree(fb_info);
+ framebuffer_release(fb_info);
break;
}
}
@@ -1126,7 +1128,7 @@ #ifdef CONFIG_SH_STORE_QUEUES
#endif

unregister_framebuffer(fb_info);
- kfree(fb_info);
+ framebuffer_release(fb_info);
}

module_init(pvr2fb_init);