From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Gabriel C <nix.or.die@googlemail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix fbcon - 'map_override' defined but not used warning
Date: Mon, 23 Jul 2007 14:18:44 +0800 [thread overview]
Message-ID: <1185171524.5046.2.camel@daplas> (raw)
In-Reply-To: <46A38486.70903@googlemail.com>
On Sun, 2007-07-22 at 18:23 +0200, Gabriel C wrote:
> Hi,
>
> I got this warning on current git:
>
> ...
>
> drivers/video/console/fbcon.c:130: warning: 'map_override' defined but not used
>
> ...
>
> Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
>
> ---
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index decfdc8..60a14de 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -127,7 +127,9 @@ static int last_fb_vc = MAX_NR_CONSOLES - 1;
> static int fbcon_is_default = 1;
> static int fbcon_has_exited;
> static int primary_device = -1;
> +#ifndef MODULE
Disrecard my other comment. This should be
#ifdef CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY
> static int map_override;
> +#endif
>
> /* font data */
> static char fontname[40];
Tony
next prev parent reply other threads:[~2007-07-23 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 16:23 [PATCH] Fix fbcon - 'map_override' defined but not used warning Gabriel C
2007-07-22 22:56 ` Antonino A. Daplas
2007-07-23 6:18 ` Antonino A. Daplas [this message]
2007-07-23 12:07 ` Gabriel C
2007-07-23 12:44 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185171524.5046.2.camel@daplas \
--to=adaplas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox