public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Ingo Molnar <mingo@elte.hu>,
	Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] slub: add lock debugging check
Date: Thu, 26 Jul 2007 20:01:38 +0200	[thread overview]
Message-ID: <1185472898.15205.4.camel@lappy> (raw)
In-Reply-To: <Pine.LNX.4.64.0707261048220.2374@schroedinger.engr.sgi.com>


Ingo noticed that the SLUB code does include the lock debugging free
check.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Christoph Lameter <clameter@sgi.com>
---
 mm/slub.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c
+++ linux-2.6/mm/slub.c
@@ -1656,6 +1656,7 @@ static void __always_inline slab_free(st
 	unsigned long flags;
 
 	local_irq_save(flags);
+	debug_check_no_locks_freed(object, s->objsize);
 	if (likely(page == s->cpu_slab[smp_processor_id()] &&
 						!SlabDebug(page))) {
 		object[page->offset] = page->lockless_freelist;



  reply	other threads:[~2007-07-26 18:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-23  9:47 2.6.23-rc1: known regressions with patches Michal Piotrowski
2007-07-23 10:25 ` Ingo Molnar
2007-07-23 22:59 ` Greg KH
2007-07-24 21:57   ` Michal Piotrowski
2007-07-24  6:21 ` Tejun Heo
2007-07-26  9:10 ` [bug] SLUB & freeing locks [was: Re: 2.6.23-rc1: known regressions with patches] Ingo Molnar
2007-07-26  9:26   ` Peter Zijlstra
2007-07-26  9:32     ` Peter Zijlstra
2007-07-26 10:50       ` Ingo Molnar
2007-07-26 17:47         ` Christoph Lameter
2007-07-26 11:08       ` Pekka Enberg
2007-07-26 11:11         ` Peter Zijlstra
2007-07-26 17:51           ` Christoph Lameter
2007-07-26 18:01             ` Peter Zijlstra [this message]
2007-07-26 17:47         ` Christoph Lameter
2007-07-26 18:04     ` Peter Zijlstra
2007-07-26 18:10       ` Christoph Lameter
2007-07-26 18:17         ` Peter Zijlstra
2007-07-26 18:54           ` [PATCH] slub: fix bug in slub debug support Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185472898.15205.4.camel@lappy \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox