From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <clameter@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [bug] SLUB & freeing locks [was: Re: 2.6.23-rc1: known regressions with patches]
Date: Thu, 26 Jul 2007 20:04:37 +0200 [thread overview]
Message-ID: <1185473077.15205.7.camel@lappy> (raw)
In-Reply-To: <1185441963.8197.67.camel@twins>
On Thu, 2007-07-26 at 11:26 +0200, Peter Zijlstra wrote:
> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c
> +++ linux-2.6/mm/slub.c
> @@ -1131,6 +1131,7 @@ static void __free_slab(struct kmem_cach
> slab_pad_check(s, page);
> for_each_object(p, s, page_address(page))
> check_object(s, page, p, 0);
> + ClearSlabDebug(page);
> }
>
> mod_zone_page_state(page_zone(page),
> @@ -1169,7 +1170,6 @@ static void discard_slab(struct kmem_cac
>
> atomic_long_dec(&n->nr_slabs);
> reset_page_mapcount(page);
> - ClearSlabDebug(page);
> __ClearPageSlab(page);
> free_slab(s, page);
> }
>
Christoph, how about this bit, it looks to me like we clear SlabDebug()
before we hit the last check in __free_slab().
next prev parent reply other threads:[~2007-07-26 18:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 9:47 2.6.23-rc1: known regressions with patches Michal Piotrowski
2007-07-23 10:25 ` Ingo Molnar
2007-07-23 22:59 ` Greg KH
2007-07-24 21:57 ` Michal Piotrowski
2007-07-24 6:21 ` Tejun Heo
2007-07-26 9:10 ` [bug] SLUB & freeing locks [was: Re: 2.6.23-rc1: known regressions with patches] Ingo Molnar
2007-07-26 9:26 ` Peter Zijlstra
2007-07-26 9:32 ` Peter Zijlstra
2007-07-26 10:50 ` Ingo Molnar
2007-07-26 17:47 ` Christoph Lameter
2007-07-26 11:08 ` Pekka Enberg
2007-07-26 11:11 ` Peter Zijlstra
2007-07-26 17:51 ` Christoph Lameter
2007-07-26 18:01 ` [PATCH] slub: add lock debugging check Peter Zijlstra
2007-07-26 17:47 ` [bug] SLUB & freeing locks [was: Re: 2.6.23-rc1: known regressions with patches] Christoph Lameter
2007-07-26 18:04 ` Peter Zijlstra [this message]
2007-07-26 18:10 ` Christoph Lameter
2007-07-26 18:17 ` Peter Zijlstra
2007-07-26 18:54 ` [PATCH] slub: fix bug in slub debug support Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185473077.15205.7.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox