Re: serial flow control appears broken

Robert Hancock
2007-07-27T18:23:47Z

Maciej W. Rozycki wrote:
> On Fri, 27 Jul 2007, Lee Howard wrote:
>
>> Okay, so let's say we've got a loop around a blocking read on the modem file
>> descriptor...
>>
>> for (;;) {
>> read some data from modem
>> process data from modem
>> if (end-of-data detected) break;
>> }
>>
>> Are you suggesting that the application should be using deasserting RTS after
>> the read and asserting it before?
>
> It certainly could -- you were asking how it would know. ;-)
>
>> I had previously thought that the control of RTS was something that the
>> serial/tty driver was supposed to do independently based on the buffer fill.
>
> The TTY line discipline driver could do that based on the amount of
> received data present in its buffer. And it should if asked to (a brief
> look at drivers/char/n_tty.c reveals it does; obviously there may be a bug

Really, where? In my look through the code I haven't found any mechanism
that would result in RTS being lowered based on TTY buffers filling up,
at least not in the 8250 case.

In this situation, though, it appears it's not the TTY buffers that are
filling but the UART's own buffer. I would think this must be caused by
some kind of interrupt latency that results in not draining the FIFO in
time.

> somewhere though). So could e.g. the SLIP and PPP line discipline
> drivers, though the criteria might be different (apparently they do not,
> which is a shame).
>
> The serial drivers have nothing to do about it -- all they can do is
> pushing data upstream, to the discipline driver. They can provide an
> interface to hardware flow control features though, if implemented by a
> given UART.
>
> Maciej
>