The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: reduce pagetable-freeing latencies
Date: Sun, 29 Jul 2007 08:36:20 +1000	[thread overview]
Message-ID: <1185662181.5495.325.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0707280627110.26545@blonde.wat.veritas.com>


> The onstack array seems fine to me, even if you do end up deciding on
> an array of one.  Is there any evidence that it's a problem getting a
> page for the freeing (other than in circumstances that are already
> badly slowed down)?  It's obvious that we need a fallback route,
> but optimizing throughput on that route seems premature.

Hrm, no evidence of that so far indeed. I'm worried by the stack usage
of the unmap_mapping_ranges() but appart from that, no.

Appart from that, yeah, I suppose we can have a macro defining how many
on-stack backup we have and adjust it if we see that being a problem.
I'm not fan of dynamic on-stack allocations.

Ben.



  reply	other threads:[~2007-07-28 22:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24  8:38 [patch] mm: reduce pagetable-freeing latencies Ingo Molnar
2007-07-24  8:54 ` Andrew Morton
2007-07-24  9:40   ` Benjamin Herrenschmidt
2007-07-24 12:13     ` Andi Kleen
2007-07-24 21:29       ` Benjamin Herrenschmidt
2007-07-25  6:44         ` Peter Zijlstra
2007-07-25  9:46           ` Andi Kleen
2007-07-25 10:08             ` Benjamin Herrenschmidt
2007-07-25 10:26               ` Andi Kleen
2007-07-25 10:46                 ` Benjamin Herrenschmidt
2007-07-26 17:11                   ` Hugh Dickins
2007-07-26 21:35                     ` Benjamin Herrenschmidt
2007-07-28  1:36           ` Benjamin Herrenschmidt
2007-07-28  5:54             ` Hugh Dickins
2007-07-28 22:36               ` Benjamin Herrenschmidt [this message]
2007-07-24 11:22   ` Ingo Molnar
2007-07-24  9:40 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185662181.5495.325.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox