From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Kay Sievers <kay.sievers@vrfy.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 03/11] kobject: fix link error when CONFIG_HOTPLUG is disabled
Date: Mon, 30 Jul 2007 15:09:25 -0700 [thread overview]
Message-ID: <11858333823900-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <11858333772499-git-send-email-gregkh@suse.de>
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Leaving kobject_actions[] in kobject_uevent.c, but putting it outside
the #ifdef looks indeed like the best solution to me. This way, we
avoid adding #ifdef CONFIG_HOTPLUG into core.c, when all other
functions called do not need such a thing.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
lib/kobject_uevent.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 6a80c78..df02814 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -25,14 +25,6 @@
#define BUFFER_SIZE 2048 /* buffer for the variables */
#define NUM_ENVP 32 /* number of env pointers */
-#if defined(CONFIG_HOTPLUG)
-u64 uevent_seqnum;
-char uevent_helper[UEVENT_HELPER_PATH_LEN] = "/sbin/hotplug";
-static DEFINE_SPINLOCK(sequence_lock);
-#if defined(CONFIG_NET)
-static struct sock *uevent_sock;
-#endif
-
/* the strings here must match the enum in include/linux/kobject.h */
const char *kobject_actions[] = {
"add",
@@ -43,6 +35,14 @@ const char *kobject_actions[] = {
"offline",
};
+#if defined(CONFIG_HOTPLUG)
+u64 uevent_seqnum;
+char uevent_helper[UEVENT_HELPER_PATH_LEN] = "/sbin/hotplug";
+static DEFINE_SPINLOCK(sequence_lock);
+#if defined(CONFIG_NET)
+static struct sock *uevent_sock;
+#endif
+
/**
* kobject_uevent_env - send an uevent with environmental data
*
--
1.5.2.2
next prev parent reply other threads:[~2007-07-30 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 22:08 [GIT PATCH] driver core fixes for 2.6.23-rc1 Greg KH
2007-07-30 22:09 ` [PATCH 01/11] HOWTO: adjust translation header of Japanese stable_api_nonsense.txt Greg Kroah-Hartman
2007-07-30 22:09 ` [PATCH 02/11] HOWTO: sync Japanese HOWTO Greg Kroah-Hartman
2007-07-30 22:09 ` Greg Kroah-Hartman [this message]
2007-07-30 22:09 ` [PATCH 04/11] kobject: put kobject_actions in kobject.h Greg Kroah-Hartman
2007-07-30 22:09 ` [PATCH 05/11] kernel-doc fixes for PCI and drivers/base/ Greg Kroah-Hartman
2007-07-30 22:09 ` [PATCH 06/11] Fix Doc/sysfs-rules typos Greg Kroah-Hartman
2007-07-30 22:09 ` [PATCH 07/11] stable_api_nonsense.txt: Disambiguate the use of "this" by using "that" to refer to the syscall interface Greg Kroah-Hartman
2007-07-30 22:09 ` [PATCH 08/11] driver core: revert "device" link creation check Greg Kroah-Hartman
2007-07-30 22:09 ` [PATCH 09/11] kset: kernel-doc cleanups Greg Kroah-Hartman
2007-07-30 22:09 ` [PATCH 10/11] kobject: update documentation Greg Kroah-Hartman
2007-07-30 22:09 ` [PATCH 11/11] modules: better error messages when modules fail to load due to a sysfs problem Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11858333823900-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox