public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 08/11] driver core: revert "device" link creation check
Date: Mon, 30 Jul 2007 15:09:30 -0700	[thread overview]
Message-ID: <11858334042248-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <11858334013561-git-send-email-gregkh@suse.de>

From: Cornelia Huck <cornelia.huck@de.ibm.com>

driver core: revert "device" link creation check

Commit 2ee97caf0a6602f749ddbfdb1449e383e1212707 introduced an extra
check on when to create the "device" symlink. Unfortunately, this
breaks input, so let's revert to the old behaviour.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Acked-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/base/core.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index b9bb399..e6738bc 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -678,8 +678,7 @@ static int device_add_class_symlinks(struct device *dev)
 		if (error)
 			goto out_subsys;
 	}
-	/* only bus-device parents get a "device"-link */
-	if (dev->parent && dev->parent->bus) {
+	if (dev->parent) {
 		error = sysfs_create_link(&dev->kobj, &dev->parent->kobj,
 					  "device");
 		if (error)
-- 
1.5.2.2


  reply	other threads:[~2007-07-30 22:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30 22:08 [GIT PATCH] driver core fixes for 2.6.23-rc1 Greg KH
2007-07-30 22:09 ` [PATCH 01/11] HOWTO: adjust translation header of Japanese stable_api_nonsense.txt Greg Kroah-Hartman
2007-07-30 22:09   ` [PATCH 02/11] HOWTO: sync Japanese HOWTO Greg Kroah-Hartman
2007-07-30 22:09     ` [PATCH 03/11] kobject: fix link error when CONFIG_HOTPLUG is disabled Greg Kroah-Hartman
2007-07-30 22:09       ` [PATCH 04/11] kobject: put kobject_actions in kobject.h Greg Kroah-Hartman
2007-07-30 22:09         ` [PATCH 05/11] kernel-doc fixes for PCI and drivers/base/ Greg Kroah-Hartman
2007-07-30 22:09           ` [PATCH 06/11] Fix Doc/sysfs-rules typos Greg Kroah-Hartman
2007-07-30 22:09             ` [PATCH 07/11] stable_api_nonsense.txt: Disambiguate the use of "this" by using "that" to refer to the syscall interface Greg Kroah-Hartman
2007-07-30 22:09               ` Greg Kroah-Hartman [this message]
2007-07-30 22:09                 ` [PATCH 09/11] kset: kernel-doc cleanups Greg Kroah-Hartman
2007-07-30 22:09                   ` [PATCH 10/11] kobject: update documentation Greg Kroah-Hartman
2007-07-30 22:09                     ` [PATCH 11/11] modules: better error messages when modules fail to load due to a sysfs problem Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11858334042248-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=cornelia.huck@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox