public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, jens.axboe@oracle.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FRV: Make BSG declarations dependent on CONFIG_BLOCK
Date: Wed, 01 Aug 2007 12:30:21 -0500	[thread overview]
Message-ID: <1185989421.3468.94.camel@localhost.localdomain> (raw)
In-Reply-To: <28317.1185979496@redhat.com>

On Wed, 2007-08-01 at 15:44 +0100, David Howells wrote:
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
> 
> > Are you sure you're testing with git head?  CONFIG_BLK_DEV_BSG cannot be
> > set unless CONFIG_BLOCK is (which was a bug in previous releases now
> > fixed in git head ... unless the fix has gone wrong?).
> 
> Neither CONFIG_BLK_DEV_BSG nor CONFIG_BLOCK are set.  The problem is that the
> stub BSG functions refer to undefined structures when CONFIG_BLOCK=n.

Hmm, then isn't the fix to add a struct request_queue; and other
definitions above the stub functions?

What is the file that's causing this actual problem ... as in what still
needs to pull in the block headers if CONFIG_BLOCK=n (or more properly,
could it also need to use the bsg stub functions?)

James



  reply	other threads:[~2007-08-01 17:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  9:13 [PATCH] FRV: Make BSG declarations dependent on CONFIG_BLOCK David Howells
2007-08-01 13:57 ` James Bottomley
2007-08-01 14:44   ` David Howells
2007-08-01 17:30     ` James Bottomley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-09-05 15:23 David Howells
2007-09-05 15:56 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185989421.3468.94.camel@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox