From: Rusty Russell <rusty@rustcorp.com.au>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: trenn@suse.de, Adrian Bunk <bunk@stusta.de>,
Sam Ravnborg <sam@ravnborg.org>, Jan Dittmer <jdi@l4x.org>,
Len Brown <lenb@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: RE: scripts/mod/file2alias.c cross compile problem
Date: Fri, 03 Aug 2007 08:08:20 +1000 [thread overview]
Message-ID: <1186092501.6131.154.camel@localhost.localdomain> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A0211AFF0@scsmsx411.amr.corp.intel.com>
On Thu, 2007-08-02 at 09:25 -0700, Luck, Tony wrote:
> > Adrian Bunk: scripts/mod/file2alias.c is compiled with HOSTCC and ensures that
> > kernel_ulong_t is correct, but it can't cope with different padding on
> > different architectures.
>
> Surely this is the root cause ... you can't expect that the alignment
> rules of HOSTCC to make any sense for an arbitraty target.
>
> > +#define FILLUP_LEN 7 /* dirty fix for i386 -> 64bit cross-compilation */
> >
> > struct acpi_device_id {
> > __u8 id[ACPI_ID_LEN];
> > + __u8 dummy[FILLUP_LEN];
> > kernel_ulong_t driver_data;
> > };
>
> What's so special about this structure that we get an error?
It's in mod_devicetable.h: see comment at top of that file. These
structures serve dual purpose: to describe the capabilities of the
driver to the kernel probing functions, *and* to export them to
userspace tables. The former purpose is why there's a data pointer in
there.
scripts/mod/file2alias is the program that reads this: although it can
be altered to parse 32-vs-64, Adrian's fix is the simplest.
Hope that clarifies,
Rusty.
next prev parent reply other threads:[~2007-08-02 22:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070727230741.GD15129@stusta.de>
[not found] ` <617E1C2C70743745A92448908E030B2A0209BB9D@scsmsx411.amr.corp.intel.com>
2007-07-28 1:39 ` scripts/mod/file2alias.c cross compile problem Adrian Bunk
2007-08-02 15:09 ` Thomas Renninger
2007-08-02 16:25 ` Luck, Tony
2007-08-02 16:36 ` Andreas Schwab
2007-08-02 17:40 ` Luck, Tony
2007-08-02 18:09 ` Sam Ravnborg
2007-08-02 19:15 ` Adrian Bunk
2007-08-02 19:24 ` Sam Ravnborg
2007-08-02 19:39 ` Al Viro
2007-08-02 22:08 ` Rusty Russell [this message]
2007-08-02 23:03 ` Adrian Bunk
2007-08-16 14:27 ` Thomas Renninger
2007-08-16 16:26 ` Luck, Tony
2007-08-16 17:03 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186092501.6131.154.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=jdi@l4x.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox