public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Ingo Molnar <mingo@elte.hu>,
	Gregory Haskins <ghaskins@novell.com>,
	Daniel Walker <dwalker@mvista.com>,
	linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure
Date: Mon, 06 Aug 2007 16:52:01 +0200	[thread overview]
Message-ID: <1186411921.7182.24.camel@twins> (raw)
In-Reply-To: <20070806144536.GA232@tv-sign.ru>

On Mon, 2007-08-06 at 18:45 +0400, Oleg Nesterov wrote:
> On 08/06, Peter Zijlstra wrote:

> > still this does not change the fundamental issue of a high prio piece of
> > work waiting on a lower prio task.
>        ^^^^^^^
> waiting. This is a "key" word, and this was my (perhaps wrong) point.

Yeah, its having a higher prio item processed at a lower prio that is
the problem. It might be delayed by less important issues.

But I'm feeling a question wanting to jump out of your statement, I just
fail to find it.

> > > I suspect most of the barrier/flush semantics could be replaced with
> > > completions from specific work items.
> 
> Hm. But this is exactly how it works?

Ah, I fail to be clear :-/

Yes, barriers work by enqueueing work and waiting for that one work item
to fall out, thereby knowing that all previous work has been completed.

My point was that most flushes are there to wait for a previously
enqueued work item, and might as well wait for that one.

Let me try to illustrate: a regular pattern is, we enqueue work A and
then flush the whole queue to ensure A is processed. So instead of
enqueueing A, then B in the barrier code, and wait for B to pop out, we
might as well wait for A to begin with.




  reply	other threads:[~2007-08-06 14:52 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  0:26 [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure Gregory Haskins
2007-08-01  3:52 ` Daniel Walker
2007-08-01 11:59   ` Gregory Haskins
2007-08-01 15:10     ` Daniel Walker
2007-08-01 15:19       ` Gregory Haskins
2007-08-01 15:55         ` Daniel Walker
2007-08-01 17:32           ` Gregory Haskins
2007-08-01 21:48       ` Esben Nielsen
2007-08-01 17:01   ` Peter Zijlstra
2007-08-01 17:10     ` Daniel Walker
2007-08-01 18:26       ` Oleg Nesterov
2007-08-01 18:39         ` Daniel Walker
2007-08-01 20:25           ` Oleg Nesterov
2007-08-01 18:12     ` Oleg Nesterov
2007-08-01 18:29       ` Daniel Walker
2007-08-01 20:18         ` Oleg Nesterov
2007-08-01 20:32           ` Oleg Nesterov
2007-08-01 20:43             ` Daniel Walker
2007-08-01 20:34           ` Daniel Walker
2007-08-01 20:50             ` Oleg Nesterov
2007-08-01 21:02               ` Daniel Walker
2007-08-01 21:13               ` Gregory Haskins
2007-08-01 21:34                 ` Oleg Nesterov
2007-08-01 21:59                   ` Gregory Haskins
2007-08-01 22:22                     ` Oleg Nesterov
2007-08-01 23:53                       ` Gregory Haskins
2007-08-02 19:50                         ` Oleg Nesterov
2007-08-06 11:35                           ` Gregory Haskins
2007-08-06 14:26                             ` Oleg Nesterov
2007-08-06 14:57                               ` Gregory Haskins
2007-08-06 15:36                                 ` Oleg Nesterov
2007-08-06 15:50                                   ` Gregory Haskins
2007-08-06 16:50                                     ` Oleg Nesterov
2007-08-06 16:57                                       ` Gregory Haskins
2007-08-06 11:49                           ` Ingo Molnar
2007-08-06 13:18                             ` Oleg Nesterov
2007-08-06 13:29                               ` Peter Zijlstra
2007-08-06 13:32                                 ` Peter Zijlstra
2007-08-06 14:45                                   ` Oleg Nesterov
2007-08-06 14:52                                     ` Peter Zijlstra [this message]
2007-08-06 16:40                                       ` Oleg Nesterov
2007-08-06 15:04                                     ` Gregory Haskins
2007-08-06 15:38                                       ` Oleg Nesterov
2007-08-06 19:33                           ` Oleg Nesterov
2007-08-06 19:37                             ` Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1186411921.7182.24.camel@twins \
    --to=peterz@infradead.org \
    --cc=dwalker@mvista.com \
    --cc=ghaskins@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox