From: Paul Fulghum <paulkf@microgate.com>
To: Laurent Pinchart <laurentp@cse-semaphore.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: Serial buffer memory leak
Date: Wed, 08 Aug 2007 09:52:55 -0500 [thread overview]
Message-ID: <1186584775.3508.13.camel@x2.microgate.com> (raw)
In-Reply-To: <200708081628.36897.laurentp@cse-semaphore.com>
On Wed, 2007-08-08 at 16:28 +0200, Laurent Pinchart wrote:
> The patch fixes the problem (at least under the test conditions that lead me
> to discover it in the first place). Thanks Alan.
It works here also, but I see a problem.
By deferring the flush, ioctl(TCFLSH) returns immediately
even though there is possibly still receive data being fed
to the ldisc.
If this is followed immediately by a read() then the
application gets unexpected (stale) data defeating the
purpose of the TCFLSH.
tty_buffer_flush() needs to wait for buf.flushpending to clear.
--
Paul Fulghum
Microgate Systems, Ltd
next prev parent reply other threads:[~2007-08-08 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 9:58 Serial buffer memory leak Laurent Pinchart
2007-08-08 13:45 ` Alan Cox
2007-08-08 14:11 ` Paul Fulghum
2007-08-08 14:28 ` Laurent Pinchart
2007-08-08 14:52 ` Paul Fulghum [this message]
2007-08-08 15:16 ` Alan Cox
2007-08-08 15:32 ` Alan Cox
2007-08-08 17:35 ` Paul Fulghum
2007-08-08 14:26 ` Frederik Deweerdt
2007-08-08 14:13 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186584775.3508.13.camel@x2.microgate.com \
--to=paulkf@microgate.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=laurentp@cse-semaphore.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox