Re: + remove-current-defines-and-uses-of-pr_err-add-pr_emerg.patch added to -mm tree

[Joe Perches <joe@perches.com>]

On Wed, 2007-08-08 at 22:02 +0200, Jean Delvare wrote:
> On Tue, 7 Aug 2007 13:19:49 -0700, Andrew Morton wrote:
> > On Fri, 03 Aug 2007 15:16:09 -0700
> > Joe Perches <joe@perches.com> wrote:
> > > Add new pr_<level> printk(KERN_<level> fmt "\n", ##arg) to kernel.h
> > > pr_info and pr_debug are unchanged
> > > Remove local pr_err #defines
> > > Convert current uses of pr_err
> > OK, I've lost the plot here.  If we have now converged on an
> > agreeable patch, please resend it?
> I don't think we have, no.
> It's not even clear what Joe is trying to achieve.

Goals in desired implementation sequence:

1 Standardization of pr_<level>
2 Correctness of single line uses of pr_<level>
3 Correctness of multiple line uses of printk(<level>)
4 Removal of local near equivalents of pr_<level>
5 Standardization of pr_<level> as single line only
6 Conversion of single line printk(KERN_<level> to pr_level
7 Standardize local #defines to enable/print pr_<level>
  __file__/__func__/__line__
8 Minimization/elimination of interleaved log messages

cheers, Joe